BA-6750: App crashes when attempting to view seller storefront - #15
Open
mekiti wants to merge 1 commit into
Open
BA-6750: App crashes when attempting to view seller storefront#15mekiti wants to merge 1 commit into
mekiti wants to merge 1 commit into
Conversation
kenworley
requested changes
Aug 7, 2026
kenworley
left a comment
kenworley
left a comment
Contributor
There was a problem hiding this comment.
We might want to keep this change, but it doesn't fix the crash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found a lazy var, which initializes on first access and that initialization is writing to the backing storage. The read path, getCached(), ran inside lock.reading, WrapModelLock.reading is queue.sync on a concurrent dispatch queue with no barrier so multiple threads execute it simultaneously. This seems like one thread tries to read while another tries to write, which leads to memory corruption, which is why crash happens.
What AI says:
Release + real ARM device: optimizer and scheduling widen the window enough to hit it; Debug/simulator timing almost never lined the two accesses up.
Enabling ThreadSanitizer serialized memory accesses enough that the corruption window closed (crash "disappeared"), but TSan still reported the race — which is how we confirmed it: WARNING: ThreadSanitizer: data race … WrapModel.cachedValues.getter, one thread read / one thread write, same address.