Repository navigation
Canary: end every failed check with an ::error:: line - #5
Merged
Merged
Conversation
A canary run through the proxy secret that exited nonzero ended red with no annotation, and a missing or malformed output file showed only a traceback. The check step now prints an ::error:: line on every failure path, and the proxy-path message says that a proxy rejecting its credential (HTTP 407) reaches Chromium as a navigation timeout. smoke_test.py runs the workflow's check snippet with every exit code, with and without the proxy secret, and requires an ::error:: line. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CKsd7q25N19WzUZjrAdzx8
… no workflows Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CKsd7q25N19WzUZjrAdzx8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On 2026-10-20 the canary was dispatched with the proxy secret set. The scraper exited 5 (every navigation through the proxy timed out), and the check step ended the job red with only
canary requires EXIT_OK=0, got 5. That step printed an::error::line only for a run without the proxy secret, so a failure through the proxy left no annotation. A missing or malformed output file also produced only a traceback.Change
::error::line. This covers a missing sidecar and a failed row assertion.::error::line with the exit code and the meaning of each code. The line also notes that a proxy rejecting its credential (HTTP 407) reaches Chromium as a navigation timeout, so an exit 5 should be checked against the secret first. On 2026-10-20 the same proxy credential produced Chromium navigation timeouts and an HTTP 407 for a plain HTTP client in another repository of this family.smoke_test.pygets a new check. It extracts the workflow'spython3 -ccheck snippet and runs it in an empty directory with exit codes 0, 1, 3, 4, 5 and 6, with and without the proxy secret. Each run must fail and print::error::.Evidence
requirements.txt), and so do.github/ci_checks.pyand--sample-check.canary.ymlwith the new check makes the check fail. Exit 0 with a missing sidecar printed no::error::.canary.ymlwithout the proxy-pathprintmakes the check fail on('true', '1', ...), with no::error::printed. After each control the file was restored and the suite was green again.safe_load).Not changed
🤖 Generated with Claude Code
https://claude.ai/code/session_01CKsd7q25N19WzUZjrAdzx8