Repository navigation
refactor: remove the three flag-rate figures from the bitcoin post - #40
Merged
Merged
Conversation
FlagRateMempool, FlaggedBlocks and PoolFlagHeatmap all read invented placeholder data, so they showed a pattern nobody measured. Remove the components, their mount points, their libs and tests, and the section that held them. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Removes
FlagRateMempool,FlaggedBlocksandPoolFlagHeatmapfrom the bitcoin post:diagrams/FlagRateMempool.{astro,tsx}+lib/flag-rate.tsdiagrams/FlaggedBlocks.{astro,tsx}+lib/flagged-blocks.tsand its testdiagrams/PoolFlagHeatmap.{astro,tsx}+lib/pool-flag-rate.ts,lib/pool-flag-sample.tssrc/posts/bitcoin/index.mdxWhy
All three read invented placeholder data, so they drew a pattern nobody measured.
Notes for the reviewer
## Flag rate vs mempool congestionsection is gone, including its "The numbers here are placeholder data." line. That heading held only these three figures, so keeping it would leave an empty section with a caption about data that no longer exists.PoolFlagHeatmaphad its ownflaggedBlocksfield, unrelated to the deletedflagged-blocks.ts.lib/offchain-revenue.tsandlib/accelerator-pools.tsuse the same field name and are untouched.--pool-1…--pool-5and.pool-restinglobal.css(.pool-restwas used only byFlaggedBlocks; the accelerator chart uses--series-*directly).data/epochs.jsonandscripts/generate-bitcoin-epochs.mjswere already unused before this change.npm run verifypasses: format check,astro check, build, 60 tests.🤖 Generated with Claude Code