FSHSP-226 fix(schematics): align @schematics/angular with @angular-devkit/schematics - #159
Merged
Merged
Conversation
…vkit/schematics #156 moved @angular-devkit/schematics to 22.1.8 while @schematics/angular, filed in Dependabot's dev-tooling group, stayed at 22.1.7 with its own 22.1.7 devkit. Two incompatible `Rule` types: `schematics:build` fails, so the publish workflow's verify job would stop before any release. Bump @schematics/angular to 22.1.8, move it to the angular group so it follows the devkit, and build the schematics in PR checks: nothing did before, which is how #156 went green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: FSHSP-226. Blocks the 0.12.0 release (FSHSP-227).
Problem
#156 moved
@angular-devkit/schematicsto 22.1.8.@schematics/angularsits in Dependabot'sdev-toolinggroup (#155, closed), so it stayed at 22.1.7 and pulls its own 22.1.7 devkit. Two incompatibleRuletypes:pnpm schematics:buildfails with TS2322, and theverifyjob ofpublish-ui-kit.ymlwould stop at "Build the schematics package". PR checks never build the schematics, so #156 went green.Fix
@schematics/angular22.1.7 → 22.1.8: one devkit 22.1.x left in the lockfile.dependabot.yml:@schematics/angularjoins theangulargroup, so it follows the devkit.pr-checks.yml: newBuild the schematics packagestep inLint, types & docs.No CHANGELOG entry: dev dependency only, the published tarballs are unchanged (the schematics' peer range stays
^22.0.0).Test plan
pnpm schematics:buildfails on currentmain(TS2322) and passes with this branch, on a clean install (fresh worktree)Lint, types & docsruns the new step green🤖 Generated with Claude Code