Repository navigation
chore(convert-pins): move the QAT conversion toolchain to its newest compatible releases - #240
github-actions[bot] wants to merge 1 commit into
Conversation
420c8ee to
7bf76ba
Compare
…compatible releases
7bf76ba to
1bf784c
Compare
|
Checked this bump before merge. It is good to merge; one behaviour change is noted at the end. Versions. torch 2.15.0 and torchvision 0.29.2 are the newest stable releases on PyPI (both uploaded 2026-10-28). torchvision 0.29.2 declares Install and run. The full pin set installs into a Python 3.12 venv, and Ledger. No running or pending row's arm reads Rebased onto main at f53eac1 so CI runs against the current tree (the earlier runs were Behaviour change: Python 3.10 drops out. torch 2.15.0 publishes no |
88plug
left a comment
There was a problem hiding this comment.
Independent review of 1bf784c: approve, no defects found.
- Versions. torch 2.15.0 and torchvision 0.29.2 are the newest stable releases on PyPI. torchvision v0.29.2's release notes say it is compatible with PyTorch 2.14 and later (ABI stable since 0.29.0; 0.29.1 relaxed the pin to
torch>=2.14), so the pair is supported upstream, not only allowed by metadata. optimum-intel 2.2.0 allows both (torch>=2.1,torchvision).hack/bump-convert-pins --dry-run(packaging 26.3) on this branch moves nothing. - Resolution.
uv pip compileof the pin set for x86_64 manylinux resolves on Python 3.11, 3.12, 3.13 and 3.14. It does not resolve on 3.10, because torch 2.15.0 requires Python >= 3.11. The README's supported hosts are Ubuntu 24.04 (3.12) and 26.04 (3.14.3), Fedora, Arch and Manjaro, so no supported host is affected. torchvision's!=3.14.1exclusion is unchanged from 0.29.1. - Conversion control. I built a tiny random Gemma4ForConditionalGeneration from the QAT checkpoint's own config.json (rev f1e06dc5), with the MoE block,
attention_k_eq_v, the sliding/full layer pattern and the vision tower kept, and exported it withconversion_job's flags under main's pins and under this branch's pins (CPU torch, Python 3.14). All six.binfiles are byte-identical. With tensor names stripped, the XML files differ only in the recordedpytorch_version. - Ledger. No row reads
console/convert-pins.json: H54q's OVQ comes frombench/h54/ov-export-venv.txt, and the crescent exports come frombench/eatflow/crescent/ov-export-venv.txt. Neither file changes here, and EXPERIMENTS.md does not change. No amendment is needed. - Suites on this head pass: console_test (61/0), audit_test (49/0), console_mcp_test, model_opt_test (37/0), gate_merge_test (31/0), claims_check_test (81/0), claims_check, ledger_drift_check_test and ledger_drift_check (41 files, 81 rows). The PR body's test claim matches run 40873203081: console 61/0 and model_opt 37/0.
- Main has since moved to d997ea8 (EXPERIMENTS.md and bench/flashnext/h60.sh). The branch still merges cleanly, and the merge gate will re-sync it before CI.
|
Closing as superseded by #238. #238 (merged 2026-10-29 22:10Z as 012b4e9) moved console/convert-pins.json to the same pins this PR carries: torch 2.15.0 and torchvision 0.29.2. Merging this branch into main (74ff63e) gives main's tree exactly, so a squash here would put an empty commit on main. Both pins are still the newest releases on PyPI as of 2026-10-30 00:05Z. The bump job skips the PR step when nothing moved, so it would not close this PR by itself. The next nightly that finds a newer release opens a fresh one. |
…pen alarms A PR that GITHUB_TOKEN opens or pushes gets pull_request runs held for approval (#240 sat with CI action_required), while a workflow_dispatch run needs none. ci.yml now takes workflow_dispatch, and hack/bot-ci-dispatch runs it on each same-repo autobump/* branch opened by github-actions[bot] that has no run at its head, re-running a first-attempt failure once. It keeps one bot ci.yml run in flight (BOT_CI_MAX_INFLIGHT) and defers while a human PR's CI is queued, since one run is about 39 jobs against a 20-40 job pool. The three nightly PR jobs call it after create-pull-request, and the new hourly 'Bot sweep' workflow (job ci-fill) fills in what they deferred. hack/autobump-branch-reset generalises the digest job's stale-branch step to all three PR jobs: a bump branch whose workflow files differ from main's is deleted before create-pull-request, whose force-push GitHub would refuse. The merge gate's checks move to hack/gate_lib.sh. ci_status reads ci.yml at a SHA through a pull_request run or a dispatch run on the PR branch; once the dispatched run is green, held entries of 'CI' and 'Auto-merge Dependabot PRs' no longer block. base_ok ignores release-only bot commits on main, so the three release commits per launcher release no longer force a sync. The gate prints every open ci-alarm issue and refuses (exit 4) a PR that changes .github/ or shipped paths while one is not acked; ledger, docs, bench and test PRs are never refused. ci.yml gains a last job, alarms, which warns on every open ci-alarm issue and on a missing, disabled or quiet Watchdog workflow, and never fails. dependabot-auto-merge.yml is deleted: it ran gh pr merge --auto on an unprotected main, merged nothing in 500 runs, and held a run on every bot PR.
hack/bump-convert-pinsmoved these pins inconsole/convert-pins.json:tests/console_test.shandtests/model_opt_test.shpassed in the workflowrun that opened this PR.