Repository navigation
fix: preserve the sign of Telegram DC ids - #578
Open
AndreyOsipuk wants to merge 2 commits into
Open
AndreyOsipuk wants to merge 2 commits into
AndreyOsipuk wants to merge 2 commits into
Conversation
A negative DC id in the client handshake is how Telegram clients ask for the media counterpart of a DC (-2 is DC 2 media). handshakeFrame.dc() dropped the sign, so media requests were proxied to the regular DC. Keep the sign from the client frame through to the server handshake. DC addresses are still looked up by the absolute DC number, and the unknown-DC fallback keeps the sign as well.
The fuzz test asserted the old behaviour (a negative DC id loses its sign), which is exactly what this change fixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A negative DC id in the client handshake is how Telegram clients ask for the media counterpart of a DC (
-2is DC 2 media).handshakeFrame.dc()turned it into a positive number, so media requests were proxied to the regular DC.Changes:
handshakeFrame.dc()keeps the sign (0 still means the default DC);doTelegramCalllooks addresses up by the absolute DC number and passes the signed id to the server handshake; the unknown-DC fallback keeps the sign too;TestNegativeDCfor the frame, the fuzz target accepts negative ids.We have been running this in production since late July (through mtg-multi); media traffic shows up as
dc="-2"etc. in the Prometheus metrics. The same change for mtg-multi: dolonet#43.go vet ./mtglib/...andgo test ./mtglib/...pass.