Skip to content

Relax tolerances in DiLoCo, MoE, and Attention tests to fix TPU7x failures#4455

Merged
copybara-service[bot] merged 1 commit into
mainfrom
fix/relax-tolerance-TPUv7x-tests
Jul 16, 2026
Merged

Relax tolerances in DiLoCo, MoE, and Attention tests to fix TPU7x failures#4455
copybara-service[bot] merged 1 commit into
mainfrom
fix/relax-tolerance-TPUv7x-tests

Conversation

@hsuan-lun-chiang

@hsuan-lun-chiang hsuan-lun-chiang commented Jul 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

This PR relaxes tolerances to fix TPU7x failures, and enables TPU7x tests on PR.

Test

TPUv7x Tests

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@hsuan-lun-chiang hsuan-lun-chiang force-pushed the fix/relax-tolerance-TPUv7x-tests branch from 5834c16 to 7b12d08 Compare July 15, 2026 02:59
@hsuan-lun-chiang hsuan-lun-chiang force-pushed the fix/relax-tolerance-TPUv7x-tests branch from 4ae3adb to 597ad8c Compare July 15, 2026 10:21
@copybara-service copybara-service Bot merged commit 0fe4dc7 into main Jul 16, 2026
110 of 131 checks passed
@copybara-service copybara-service Bot deleted the fix/relax-tolerance-TPUv7x-tests branch July 16, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xibinliu xibinliu xibinliu approved these changes
@NuojCheng NuojCheng NuojCheng approved these changes
@gobbleturk gobbleturk Awaiting requested review from gobbleturk gobbleturk is a code owner
@khatwanimohit khatwanimohit Awaiting requested review from khatwanimohit khatwanimohit is a code owner
@shralex shralex Awaiting requested review from shralex shralex is a code owner
@parambole parambole Awaiting requested review from parambole
@bvandermoon bvandermoon Awaiting requested review from bvandermoon bvandermoon is a code owner
@richjames0 richjames0 Awaiting requested review from richjames0 richjames0 is a code owner
@darisoy darisoy Awaiting requested review from darisoy darisoy is a code owner
@huytransformer huytransformer Awaiting requested review from huytransformer huytransformer is a code owner
@abhinavclemson abhinavclemson Awaiting requested review from abhinavclemson abhinavclemson is a code owner
@vipannalla vipannalla Awaiting requested review from vipannalla vipannalla is a code owner
@RissyRan RissyRan Awaiting requested review from RissyRan RissyRan is a code owner
@gagika gagika Awaiting requested review from gagika gagika is a code owner
@SurbhiJainUSC SurbhiJainUSC Awaiting requested review from SurbhiJainUSC SurbhiJainUSC is a code owner
@hengtaoguo hengtaoguo Awaiting requested review from hengtaoguo hengtaoguo is a code owner
@A9isha A9isha Awaiting requested review from A9isha A9isha is a code owner
@aireenmei aireenmei Awaiting requested review from aireenmei aireenmei is a code owner
@jiangjy1982 jiangjy1982 Awaiting requested review from jiangjy1982 jiangjy1982 is a code owner
@suexu1025 suexu1025 Awaiting requested review from suexu1025 suexu1025 is a code owner
@NicoGrande NicoGrande Awaiting requested review from NicoGrande
@dipannita08 dipannita08 Awaiting requested review from dipannita08 dipannita08 is a code owner
@igorts-git igorts-git Awaiting requested review from igorts-git igorts-git is a code owner

Assignees

No one assigned

Labels

pull ready

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hsuan-lun-chiang @xibinliu @NuojCheng