fix(test): improve test_scan_layers_mismatch_tpu assertion#4457
Draft
mesakhcienet wants to merge 1 commit into
Draft
fix(test): improve test_scan_layers_mismatch_tpu assertion#4457mesakhcienet wants to merge 1 commit into
mesakhcienet wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the assertion in
test_scan_layers_mismatch_tputo expect the correct error message.test_scan_layers_mismatch_tpuwas failing because the framework raises"Checkpoint does not match the model..."when attempting to restore a checkpoint with mismatchedscan_layersin the pre-training workflow. The test was still asserting an outdated error message ("Configuration mismatch"or"Failed to restore checkpoint").test_scan_layers_mismatch_tpuwas producing false negatives (failing tests when the underlying code correctly caught the issue)."Checkpoint does not match the model"to the list of accepted error strings intests/integration/checkpointing_test.py::test_scan_layers_mismatch_tpu.from_pretrained(metadata check) andtrain_main(weight alignment check) in the future to improve consistency.Bug : https://b.corp.google.com/issues/532182112
Tests
Run the affected unit test using
pytestto ensure it passes with the new assertions:ValueErrorand correctly validate the exception message.Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.