Skip to content

Decode keystore in workflow instead of Gradle" #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nbassler merged 1 commit into from
Apr 26, 2026
Merged

Decode keystore in workflow instead of Gradle" #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,14 @@ jobs:
"cmake;3.22.1" \
--sdk_root=$ANDROID_SDK_ROOT

- name: Decode keystore
run: echo "${{ secrets.KEYSTORE_BASE64 }}" | base64 -d > $RUNNER_TEMP/keystore.jks

- name: Build signed release AAB
env:
KEYSTORE_BASE64: ${{ secrets.KEYSTORE_BASE64 }}
KEYSTORE_PATH: ${{ runner.temp }}/keystore.jks
KEYSTORE_PASSWORD: ${{ secrets.KEYSTORE_PASSWORD }}

Copilot AI Apr 26, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow no longer passes a key password env var, but Gradle still needs keyPassword to sign. If the key password is different from the keystore password, the signing step will fail. Recommend reintroducing KEY_PASSWORD: ${{ secrets.KEY_PASSWORD }} (or similar) and wiring Gradle to use it for keyPassword.

Suggested change
KEYSTORE_PASSWORD: ${{ secrets.KEYSTORE_PASSWORD }}
KEYSTORE_PASSWORD: ${{ secrets.KEYSTORE_PASSWORD }}
KEY_PASSWORD: ${{ secrets.KEY_PASSWORD }}

Copilot uses AI. Check for mistakes.
KEY_ALIAS: ${{ secrets.KEY_ALIAS }}
KEY_PASSWORD: ${{ secrets.KEY_PASSWORD }}
run: ./gradlew bundleRelease

- name: Rename AAB with version
Expand Down
11 changes: 4 additions & 7 deletions app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,9 @@ android {

signingConfigs {
release {
def b64 = System.getenv("KEYSTORE_BASE64")
if (b64) {
def ks = file("${buildDir}/keystore.jks")
ks.parentFile.mkdirs()
ks.bytes = b64.decodeBase64()
storeFile = ks
def ksPath = System.getenv("KEYSTORE_PATH")
if (ksPath) {
storeFile = file(ksPath)
}
storePassword = System.getenv("KEYSTORE_PASSWORD") ?: ""
keyAlias = System.getenv("KEY_ALIAS") ?: "dedx-upload"
Expand Down Expand Up @@ -57,7 +54,7 @@ android {
release {
minifyEnabled = false
proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), 'proguard-rules.pro'
if (System.getenv("KEYSTORE_BASE64")) {
if (System.getenv("KEYSTORE_PATH")) {
signingConfig = signingConfigs.release
}
}
Expand Down
Loading