Repository navigation
Conversation
veblush
force-pushed
the
fix/mve-s4-vld2q-alignment-and-tails
branch
from
October 29, 2026 20:48
4752123 to
ded12dd
Compare
Contributor
|
Thanks for this. Can you make datasets reproducible through existing generators and TFL/TFLM reference kernels following unit test conventions (Tests/UnitTest/README.md:147)? |
veblush
force-pushed
the
fix/mve-s4-vld2q-alignment-and-tails
branch
from
November 3, 2026 00:27
ded12dd to
33b0512
Compare
Contributor
Author
Done. Rebased on main and switched the s4 conv and FC tests over to datasets generated from test_plan.json. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MVE
VLD20.8/VLD21.8(vld2q_s8) require 4-byte alignment and raise an alignment UsageFault otherwise, even whenCCR.UNALIGN_TRP == 0. Inarm_nn_vec_mat_mult_t_s4,arm_nn_mat_mult_nt_t_s4, andarm_convolve_even_s4, row pointers after row 0 are only byte-aligned when the row stride is not a multiple of 4.Add an
arm_nn_vld2q_s8helper that falls back to byte gather loads when the pointer is not 4-byte aligned, with the alignment check hoisted outside each inner loop.