fix: QuantizationInfo equality operator overload by treating implicit offset as zero#1293
fix: QuantizationInfo equality operator overload by treating implicit offset as zero#1293morgolock wants to merge 1 commit into
Conversation
gunes-arm
left a comment
There was a problem hiding this comment.
Please link tickets if any
6c1271a to
338544f
Compare
gunes-arm
left a comment
There was a problem hiding this comment.
fix: treat equivalent uniform QuantizationInfo as equal
Please start with capital letter, i.e. "fix: Treat ..."
Also, please change the PR title and description accordingly.
Also, what do you think about the following commit message. It rings more bells when read in release notes:? fix: QuantizationInfo equality operator overload by treating implicit offset as zero |
Yes, sorry, I had made the mental link between the request and the release notes but somehow I forgot it again :) |
338544f to
e13b7e1
Compare
What's your opinion on the commit message title? (+ PR description ought to change). |
Apologies, sorted now. I don't have a ticket for this. |
Thanks a lot Pablo. You didn't say what you think about the proposed commit message title. |
… offset as zero Update QuantizationInfo::operator== to compare normalized uniform() values when both operands are effectively per-layer, while preserving strict vector equality for per-channel quantization info. This makes equivalent qinfo such as QuantizationInfo(1.0f) and QuantizationInfo(1.0f, 0) compare equal, avoiding incorrect dispatch differences for paths that rely on QuantizationInfo equality. Add UNIT coverage for equivalent uniform qinfo, differing uniform qinfo, and per-channel equality behavior, and remove the pooling-specific regression coverage. Signed-off-by: Pablo Marquez Tello <pablo.tello@arm.com> Change-Id: I54ab2cc9b2fae810b9d2767676097858eb8621c8
e13b7e1 to
27eb4b8
Compare
Changed the title now to Thanks. |
Update QuantizationInfo::operator== to compare normalized uniform() values when both operands are effectively per-layer, while preserving strict vector equality for per-channel quantization info.
This makes equivalent qinfo such as QuantizationInfo(1.0f) and QuantizationInfo(1.0f, 0) compare equal, avoiding incorrect dispatch differences for paths that rely on QuantizationInfo equality.
Add UNIT coverage for equivalent uniform qinfo, differing uniform qinfo, and per-channel equality behavior, and remove the pooling-specific regression coverage.
Change-Id: I54ab2cc9b2fae810b9d2767676097858eb8621c8