Add card ui_schema validation guard and fix drift (#199)#260
Merged
rosspeili merged 1 commit intoJul 20, 2026
Conversation
Introduce skillware.core.ui_schema helpers and parametrized CI fixtures for all 13 output-card registry skills. Align mica_module and pii_masker card.json with execute() output, document the workflow in CONTRIBUTING and TESTING, and fix pdf_form_filler maintainer test to use tmp_path on Windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #199.
Adds a CI guard so every registry skill with an output
card.json(ui_schema.type: card) has field keys that resolve in representativeexecute()JSON. Introducesskillware/core/ui_schema.py, fixtures for all 13 output-card skills, and alignsmica_moduleandpii_maskercards with actual return shapes. Documents the update-in-sync rule in CONTRIBUTING and TESTING. Also fixes the PDF form filler maintainer test to usetmp_pathon Windows.Type of Change
card.jsonfixes formica_moduleandpii_maskerskillware/core/ui_schema.py,tests/test_card_ui_schema.pyChecklist (all PRs)
Fixes #199)black/flake8pass locallypytest skills/andpytest tests/pass (309 tests)CHANGELOG.mdupdated under[Unreleased]examples/README.md— N/A (no example changes)pytest tests/test_registry_docs.py— N/A (no catalog/examples matrix changes)New or updated skill
Card-only updates for
compliance/mica_moduleandcompliance/pii_masker— output fields now matchexecute()JSON. No manifest, logic, or catalog page changes.Constitution and safety
N/A — validation and presentation metadata only; no runtime behavior changes except the unrelated test fix.
Related Issues
Fixes #199