Skip to content

Add card ui_schema validation guard and fix drift (#199)#260

Merged
rosspeili merged 1 commit into
ARPAHLS:mainfrom
rosspeili:feature/199-card-ui-schema-audit
Jul 20, 2026
Merged

Add card ui_schema validation guard and fix drift (#199)#260
rosspeili merged 1 commit into
ARPAHLS:mainfrom
rosspeili:feature/199-card-ui-schema-audit

Conversation

@rosspeili

Copy link
Copy Markdown
Contributor

Description

Fixes #199.

Adds a CI guard so every registry skill with an output card.json (ui_schema.type: card) has field keys that resolve in representative execute() JSON. Introduces skillware/core/ui_schema.py, fixtures for all 13 output-card skills, and aligns mica_module and pii_masker cards with actual return shapes. Documents the update-in-sync rule in CONTRIBUTING and TESTING. Also fixes the PDF form filler maintainer test to use tmp_path on Windows.

Type of Change

  • Skill Upgradecard.json fixes for mica_module and pii_masker
  • Bug Fix — Windows-safe PDF form filler maintainer test
  • Documentation — CONTRIBUTING, TESTING, contributor workflow
  • Framework Featureskillware/core/ui_schema.py, tests/test_card_ui_schema.py

Checklist (all PRs)

  • Linked GitHub issue (Fixes #199)
  • Scope matches the issue — no unrelated refactors
  • black / flake8 pass locally
  • pytest skills/ and pytest tests/ pass (309 tests)
  • CHANGELOG.md updated under [Unreleased]
  • examples/README.md — N/A (no example changes)
  • pytest tests/test_registry_docs.py — N/A (no catalog/examples matrix changes)

New or updated skill

Card-only updates for compliance/mica_module and compliance/pii_masker — output fields now match execute() JSON. No manifest, logic, or catalog page changes.

Constitution and safety

N/A — validation and presentation metadata only; no runtime behavior changes except the unrelated test fix.

Related Issues

Fixes #199

Introduce skillware.core.ui_schema helpers and parametrized CI fixtures for all 13 output-card registry skills. Align mica_module and pii_masker card.json with execute() output, document the workflow in CONTRIBUTING and TESTING, and fix pdf_form_filler maintainer test to use tmp_path on Windows.
@rosspeili
rosspeili merged commit 812ec7e into ARPAHLS:main Jul 20, 2026
6 checks passed
@rosspeili
rosspeili deleted the feature/199-card-ui-schema-audit branch July 20, 2026 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feat]: Audit registry card.json ui_schema keys against execute() output

1 participant