Repository navigation
Two roots of linears over a linear off the real line are integrated - #1780
Merged
Rafael-SOWNet merged 2 commits intoOct 5, 2026
Merged
Conversation
1/(sqrt(x) sqrt(a + b x) (1 - i x)) was declined: the closed forms for two roots of linears over a third chose between an arctangent and a logarithm by the sign of a quantity that has none off the real line, and the piecewise on it held at no point. Both forms use nothing about their root but sqrt(q)^2 = q, so the one for a positive quantity is an antiderivative whatever the quantity's phase, and with the imaginary unit in the quantity it is taken alone. Only for those two forms; the other callers of the same choice, an arcsine among them, are left as they were. Part of #718 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012sonx8iAspMiwRwokT1Ura
…real-line-beside-two-roots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #718.
1/(sqrt(x) sqrt(a + b x) (1 - i x))was answered on master with a piecewise that held at no point. 2.5.0 declined it:092b28151/(sqrt(x) sqrt(a + b x) (1 - i x))sqrt(x)/(sqrt(a + b x) (1 + i x))sqrt(x) sqrt(a + b x)/(1 + i x)Each answer is differentiated back and compared with the integrand as complex numbers at six points.
What changes.
SolveAPolynomialOverAPowerOfALinearBesideTwoRootsends with two closed forms over the roots of two linears, one forint 1/Sand one forint 1/(y S)withya third linear, each an arctangent for one sign of a quantity and a logarithm for the other, chosen byBySign: the form for the sign of a number, and both, each where it holds, for a quantity with symbols in it. Over a linear whose coefficients are not real the quantity has no sign ---i a - b < 0is NaN, the complex numbers not being ordered -- and neither arm held. Both forms use nothing about their root butsqrt(q)^2 = q, so either is an antiderivative wherever the quantity is not zero, whatever its phase; the sign only chooses the form that is real on the real line. The two calls say so now, and a quantity with the imaginary unit in it takes the form for a positive one alone, rather than a piecewise. The other callers ofBySign, an arcsine among their forms, need more of their root and are left as they were.Tests:
RootsOfLinearsOffTheRealLineIntegralTest, three rows compared as complex numbers; master answers all three with a piecewise that has no value at any of the four points.Measured first on all of Rubi's 4.3.2.1 and 4.3.3.1, 1,948 problems run, at the corpus's 5-second budget, against master
287c69a7, the branch's base:Measured then on the Rubi corpus against master
287c69a7:The corpus cannot see the change: an answer with no value at any point is filed by the harness as one it cannot check on the reals, and so is one compared as complex numbers, so master's piecewise and this branch's answers count alike. The seven problems the two builds disagreed on, run again one build at a time, are rows at the edge of the harness's patience, answered at 8 to 24 seconds by both builds where either answers; master answers five of them alone and this four, the fifth 1.1.2.4:343, at 23 seconds on master, which went the same way in two other branches' runs the same night. The figures above were measured with three other corpus runs on the machine.
The suite on the commit measured,
864693e3, passed but forIntegralAnswerCacheTest.AnIntegralWithNoAnswerStillFinishesQuickly, which allows a declined integral thirty seconds and took forty-six with four corpus runs on the machine; its class passes alone in four seconds. The allocation gate passed. The head here,0f8e76a6, merges master092b2815; the calculus and corpus tests pass on it and the library builds fornetstandard2.0.🤖 Generated with Claude Code
https://claude.ai/code/session_012sonx8iAspMiwRwokT1Ura