Repository navigation
A product of sums in the symbols multiplied out as a polynomial in the partial fractions - #1833
Merged
Rafael-SOWNet merged 4 commits intoOct 9, 2026
Merged
Conversation
…actions Part of #718. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012sonx8iAspMiwRwokT1Ura
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012sonx8iAspMiwRwokT1Ura
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012sonx8iAspMiwRwokT1Ura
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012sonx8iAspMiwRwokT1Ura
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #718.
1/((a + b x^2)^3 (c + d x^2)^3)ran past the corpus's budget, with twelve more of Rubi's: a symbolic quadratic to a power beside other factors. A sample of the stack put all the time inInLowestTermsOverTheSymbolscalled fromMultiplied. The series at a repeated quadratic's roots multiplies coefficient arrays whose entries are products of powers of sums in the symbols, andEntity.Expandmultiplies such a product out by enumerating the combinations of its terms as expressions.1/((1 + x^2)^2 (c + d + 2d x^2)^3 (1 + 2x^2))spent eighteen seconds there.InLowestTermsOverTheSymbolsnow multiplies a product of sums out as aMultivariatePolynomial, which collects its terms as it multiplies, and leaves everything else toExpand. The first version did this for every coefficient. That changed how plain sums likea - bwere spelled, and on 4.1.7'scsc(x)^2/(a - b sin(x)^4)^2, which master declines in 20 seconds, the spellings no longer matched where the partial fractions read their own output. The search then went 47 levels deep and ran past ten minutes. Only a product of sums is multiplied out as a polynomial now, and that problem is declined in 25 seconds as before.60b8111c1/((a + b x^2)^3 (c + d x^2)^3)1/((d + e x)^2 (a + b x + c x^2)^2)(A + B x)/((a + b x + c x^2)^2 (d + e x + f x^2))1/((1 + x^2)^2 (c + d + 2d x^2)^3 (1 + 2x^2))1/((a + a sec(x))^(5/2) (c + d sec(x))^3)xstands fore + f xin the last row, which is what was probed. The third answer is long: two general symbolic quadratics, with a case for each sign of each discriminant.Tests:
ARepeatedSymbolicQuadraticIntegralTest, the fourth row, differentiated back and compared at six points.Measured on 14,109 corpus problems, every one whose integrand is a rational function and every one with a secant or a cosecant in it, at the corpus's 5-second budget, against master
60b8111c:Thirteen problems are answered here and not on master: twelve of 1.1.2.3, 1.2.1.2, 1.2.1.3, 1.2.1.6, 1.2.1.9 and 1.2.2.3, and one of 4.5.2.1. None go the other way, and no problem moves between declined and past the budget. On the 13,898 both answer the time is 2,405 seconds on master and 2,176 here, 9.5% less.
The harness counts no answer wrong in either. The thirteen problems the builds disagreed on, run again one build at a time: master answers none within the budget, this all thirteen.
The suite passes: 15,185 passed, 13 skipped, none failed. The allocation gate passes: every gated benchmark allocates what the baseline says. Merged with master
983a612b: the library builds for every target, and the partial-fraction tests pass, 144.🤖 Generated with Claude Code
https://claude.ai/code/session_012sonx8iAspMiwRwokT1Ura