Repository navigation
Ship tsbindgen and clang's resource directory in the release package - #372
Merged
Merged
Conversation
tsbindgen has built alongside tslang since #367, but the release packaging step only ever staged an explicit allowlist of binaries, so it never reached the zip/tarball. It also needs clang's resource directory (stddef.h, stdint.h, ...) next to it, or it fails at runtime with "clang's resource directory not found" - findResourceDir's release-package candidate is exeDir/lib/clang/<major>, so stage 3rdParty/llvm's lib/clang folder at that path in both packages. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stddef.h,stdint.h, ...) next to it at runtime, or it fails with "clang's resource directory not found" —findResourceDir's release-package candidate isexeDir/lib/clang/<major>.3rdParty/llvm'slib/clangfolder at that path, and add thetsbindgen/tsbindgen.exebinary, in both the Windows zip and Linux tarball packaging steps.Test plan
tsbindgen(.exe)pluslib/clang/<major>/include/stddef.h🤖 Generated with Claude Code