Repository navigation
docs: remove finished plans, reviews and stale notes - #559
Merged
Merged
Conversation
Removes docs whose work is done or that nothing uses any more: the old notes (fixes.txt, todo.txt, fix/), MLIR_to_exe, a one-off debug script, the closed LowerToAffineLoops/LowerToLLVM review, the implemented hybrid-func null-this note, the merged superpowers plans, the four not_impl repros that now pass (the suite covers them), and the old-style gc_example and cmake_vulkan samples. The MLIRGen refactoring review is removed too. Its A7 section explained the "upward mailbox" const_casts; that explanation now sits on GenContext and the NOTE comments point there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleans up the top-level
docs/folder.Removed
fixes.txt,todo.txt,fix/: 2024 notes and LLVM CMake patches nothing uses.MLIR_to_exe/test_wasm.html(the wasm samples underhow/wasmstay).how/debug/debug-shared.bat: a one-off debug script with local paths, for a crash that is fixed.LowerToAffineLoops-LowerToLLVM-review.md: all findings fixed.hybrid-func-null-this-call-optimization.md: implemented.superpowers/plans/*: all merged (the specs stay).not_impl/not_impl{19,20,26,31}.ts: these now compile and run correctly; existing suite tests cover the same patterns. The other 9 still fail and stay.how/cmake/gc_example,how/cmake_vulkan: old-style samples, replaced bycmake_tslang/hello-cmake.MLIRGen-refactoring-review.md.Edited so nothing points at a removed file
NOTE: upward mailboxconst_casts. That explanation is now a comment onGenContext(MLIRGenContext.h), and the ten NOTE comments say "see GenContext".MLIRGenImpl.hheader comment: the split intoMLIRGen*.cppfiles is finished, so it no longer says it is in progress.how/cmake_bgfx/README.md: dropped the twocmake_vulkanlinks.Code changes are comments only.
🤖 Generated with Claude Code