Repository navigation
A static field's failed initializer is an error - #582
Merged
Merged
Conversation
`class A { static s: Ref<string> = null; }` compiled with no diagnostic,
while the same initializer on an instance field or a `let` is an error.
registerVariable returned no type for the field, and the field was
registered anyway: the cast error, postponed like every message, was
never shown because the module did not fail. The dynamic-import twin
of this code already checked for it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
class A { static s: Ref<string> = null; }compiled with no diagnostic. The same initializer on an instance field, or on alet, is an error ("can't cast from 'null' to 'Reference' in 'strict null mode'").Cause:
registerVariablereturns no type when the field's initializer fails, andmlirGenClassStaticFieldMemberregistered the field anyway. The cast error is postponed like every message and shown only when the module fails, so it was lost. The dynamic-import twin of this function already checked for a missing type; this adds the same check.Repro:
Now:
static_field_initializer.ts:6:32: error: can't cast from 'null' to 'Reference<string>' in 'strict null mode'. That is thenull, which is where the instance-field andletcases report too.Also now an error, as it already is for an instance field and a
let:static s: string = nullunder strict null checks.Test:
test-compile-diagnostic-location-static-field-initializer(error text and position; fails on a stack dump, an assertion, or a 1:1 location).ctest -C Release -j 8 --timeout 300: 100% passed, 0 failed out of 4089.🤖 Generated with Claude Code