Repository navigation
Fix C4018 signed/unsigned comparison warnings - #714
Merged
Merged
Conversation
Give the loop counters and the bounds check the type of the size they compare against. printDiagnostics keeps a signed counter because its inner loop walks back to index 0 with `>= 0`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the MSVC
C4018: signed/unsigned mismatchwarnings inMLIRTypeScript:MLIRGenImpl.h: the interface-thunk argument loop now uses anunsignedcounter, matchinggetNumInputs()MLIRGenVariables.cpp: the past-the-end check casts the binding index tounsignedbefore comparing it withConstArrayType::getSize()MLIRGenGenerics.cpp:inferTypeFuncTypenow uses asize_tcounterDiagnosticHelper.cpp:printDiagnosticskeeps a signed counter and castssize()instead. Its inner loop counts back to 0 with>= 0, so an unsigned counter would wrap around.Release build has no warnings; ctest -C Release: 100% passed (6082).
🤖 Generated with Claude Code