Repository navigation
-mm=own: Array's [Symbol.iterator] says @borrows("this") - #47
Merged
Merged
Conversation
It returns this.values(), which borrows the array. Needs the compiler's generator over a `this` parameter borrowing it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Array's
iterator<T>(this: T[])([Symbol.iterator]) returnsthis.values(), a generator that borrows the array under-mm=own. It now says@borrows("this"), as Map'sentries()/keys()already do. The other models ignore it.Depends on ASDAlexander77/TypeScriptCompiler#701 (a generator over its
thisparameter borrows it). Merge that first: before it,values()kept a copy of the array and@borrows("this")is refused.Tests
array_keys,array_valuesandarray_iteratornow pass, with no new failures.array_entries, becauseentries()yields[i, this[i]], a borrowed element in a tuple the caller owns.🤖 Generated with Claude Code