Repository navigation
Tests for Array<string> and Array<Shared<T>> under every model - #52
Merged
Merged
Conversation
Both compile and run under every model, -mm=own included, with the compiler's own-defaultlib-batch3 branch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on ASDAlexander77/TypeScriptCompiler#706, which makes
Array<string>andArray<Shared<T>>compile under own. Merge that first.This PR adds two tests of the
Array<T>class:array_class_stringruns every walking, copying and filling method over strings. That includesfill,filter2andforEachwith a callback that builds a captured string.array_class_shareddoes the same overShared<Item>handles, includingsplice,shiftandpop.Both run in every model. With the compiler PR, the DefaultLib suite has no failures (out of 174):
not own)These hold in release and debug, compiled and under the JIT.
🤖 Generated with Claude Code