Repository navigation
Array<T>: count and rest constructors - #53
Merged
Merged
Conversation
`new Array<number>(10)` makes ten elements and `new Array(10, 20, 30)` those three, beside `new Array([..])`. Needs the compiler's constructor-overload inference (#715) and optional-parameter overload fit (#716). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Array: count and rest constructors
Beside
constructor(private data: T[] = []),Array<T>getsconstructor(count: int = 0):new Array<number>(10)has ten elements;constructor(...args: T[]):new Array(10, 20, 30)is those three,Tinferred.Test:
tests/array_constructors_overload.ts.Needs the compiler
overloaded and rest constructors.
the type it holds; without it
new Array<int>(10)/new Array(10)run the restconstructor (length 1). The test itself uses
new Array<number>(10), which passes either way.Verification
Locally,
tests.ps1with the compiler of #716: gc, rc, none and own all pass in all fourpasses (release/debug, compile/JIT).
Known gap
-mm=own:new Array<string>("a", "b")through the rest constructor fails the own checker(
find/findLast/_with);new Array<string>(["a", "b"])works. Not exercised by the test.🤖 Generated with Claude Code