Repository navigation
NVRHI's classes regenerated with pre-alpha99's tsbindgen - #53
Merged
Merged
Conversation
tsbindgen now declares the structs of NVRHI's namespaces and makes pointer parameters and fields nullable (TypeScriptCompiler#563). core/nvrhi_classes.<os>.ts gain the structs it can lay out as tuples (DrawArguments, TextureSlice, SamplerDesc, MemoryRequirements, ...), take Refs to them instead of Opaques (draw, copyTexture, mapStagingTexture, ...), and name the ones it can't (GraphicsState, BindingSetDesc, ...) as Opaque types; the project's own tuples (STRUCTS) still replace tsbindgen's. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ASDAlexander77
force-pushed
the
nvrhi-regenerate-classes
branch
from
October 12, 2026 23:02
78de664 to
6f3dca4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerates
core/nvrhi_classes.{win32,linux}.tswithpython tools/gen_nvrhi_classes.pyand the deployed pre-alpha99 tsbindgen (ASDAlexander77/TypeScriptCompiler#563). Generated files only; the generator already handles this output (#52).What changes in the bindings
DrawArguments,TextureSlice,SamplerDesc,MemoryRequirements,IndexBufferBinding,AccelStructPrebuildInfo, the cluster operation params, ...), and the ones it can't (std::string/static_vector/std::vectorfields:GraphicsState,BindingSetDesc,FramebufferDesc, ...) as namedOpaquetypes. The project's own tuples (BufferDesc,TextureDesc,Color,ComputeState, ...) still replace tsbindgen's.Refs to those tuples instead of anonymousOpaque /* X */:draw(args: Ref<DrawArguments>),copyTexture(..., Ref<TextureSlice>, ...),mapStagingTexture,createSampler,getDesc(): Ref<SamplerDesc>, ...| null(ITexture | null,Ref<index> | null, ...); C++ references stay non-null.Testing (pre-alpha99, every
.tsobject recompiled)nvrhi_directdx12/vk andheadlessvk with-debug.headlessandnvrhi_directon x86_64,nvrhi_directon arm64 (translated).🤖 Generated with Claude Code