Repository navigation
The workarounds for tslang issues fixed in pre-alpha101 are gone - #63
Merged
Merged
Conversation
core/nvrhi_classes.* regenerated with pre-alpha101's tsbindgen, which keeps C++ overloads under their C++ name (createGraphicsPipeline, createMeshletPipeline, copyTexture; tslang picks one by the arguments). The counts in graphicsPipelineDesc() and graphicsState() are `x ? 1 : 0` again (TSLANG_ISSUES.md #14), stdString() multiplies by 256 (#15), nvrhi_direct's texture desc is `textureDesc` beside nvrhi.textureDesc (#18) and stdVectorSize's T is inferred (#13). An IFramebuffer argument fits neither createGraphicsPipeline overload (one takes `IFramebuffer | null`): createGraphicsPipeline() passes it through an `IFramebuffer | null` local (TSLANG_ISSUES.md #19). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ASDAlexander77
force-pushed
the
tslang-101-cleanups
branch
from
October 13, 2026 21:12
44cec3f to
54a1020
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased onto main after #62. Needs tslang pre-alpha101 (deployed).
core/nvrhi_classes.*regenerated with pre-alpha101's tsbindgen: C++ overloads keep their C++ name (createGraphicsPipeline,createMeshletPipeline,copyTexture), and tslang picks one by the arguments (TypeScriptCompiler#576).graphicsPipelineDesc()/graphicsState()arex ? 1 : 0tuple fields again.stdString()doesshift *= 256.textureDescagain, next tonvrhi.textureDesc(...).stdVectorSize'sTis inferred.IFramebufferargument fits neithercreateGraphicsPipelineoverload):createGraphicsPipeline()passes it through anIFramebuffer | nulllocal. Fixed in @cpp overloads take a class forT | nulland for its base class, in a partial resolve too TypeScriptCompiler#577; the local can go once a release has that fix.Verified with every TypeScript object rebuilt on pre-alpha101:
nvrhi_directwith-dx12 -debugand-vk -debugrun_jit.bat):nvrhi_direct(dx12 and vk,-debug) andheadlessheadlessandnvrhi_directpass on x86_64 and on arm64 (translated), with freshly built binaries🤖 Generated with Claude Code