Repository navigation
Textures are uploaded through NVRHI's staging textures - #70
Merged
Merged
Conversation
nvrhi.copyTextureFromStaging(): ICommandList::copyTexture's third overload, a staging texture into a texture (its arguments through `| null` locals, TSLANG_ISSUES.md #19). nvrhi_direct tests it with a command list of its own: a staging texture the CPU writes (CPU_ACCESS_WRITE, mapStagingTexture for writing, row by row at its row pitch), copied into a texture, which is read back through a staging texture: the same pixels. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The next NVRHI step: uploading textures through staging textures the CPU writes. With this, all three of
copyTexture's overloads and both ofmapStagingTexture's access modes are tested.core/nvrhi.ts:copyTextureFromStaging()isICommandList::copyTexture's third overload (staging texture into texture). Its arguments go through| nulllocals until a tslang release has @cpp overloads take a class forT | nulland for its base class, in a partial resolve too TypeScriptCompiler#577 (TSLANG_ISSUES.md Add bundles (D3D12Bundles) #19).nvrhi_directruns a staging-upload test with its own command list:CPU_ACCESS_WRITEstaging texture, mapped for writing and filled row by row at its row pitch, with a different colour per pixelVerified on tslang pre-alpha101:
nvrhi_directwith-dx12 -debugand-vk -debugnvrhi_direct(dx12 and vk,-debug) andheadlessheadlessandnvrhi_directpass on x86_64 and on arm64 (translated)🤖 Generated with Claude Code