Bindings: UnknownSchema added data property - #1799
Conversation
|
|
cabe1df to
a8974b3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1799 +/- ##
==========================================
+ Coverage 83.21% 83.25% +0.03%
==========================================
Files 180 180
Lines 13465 13479 +14
Branches 1253 1253
==========================================
+ Hits 11205 11222 +17
+ Misses 2088 2085 -3
Partials 172 172
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
This looks good to me. Once this lands, then this feature in Raven should be easy to implement: OpenTimelineIO/raven#26 @ssteinbach do you have any concerns with this? |
jminor
left a comment
There was a problem hiding this comment.
Summarizing discussion thread: could you alter data() to return a copy of _data?
a8974b3 to
bea1d48
Compare
bea1d48 to
9f47a35
Compare
9f47a35 to
3e32272
Compare
3e32272 to
fbe8c3b
Compare
|
@jminor this should be good to re-review. |
|
@timlehr @natchar
Output from log:
Looks like we need to update the rtd config file. Perhaps in a separate PR? |
|
I've submitted a PR to unblock this. Sorry about the delay. |
|
The main branch should be at a good state to continue with this PR. |
4123122 to
3094223
Compare
|
@jminor seems like your comment has been adressed. Is this good to be approved? |
Signed-off-by: Natchar Ratanasirigulchai <natchar.r@outlook.com>
Signed-off-by: Natchar Ratanasirigulchai <natchar.r@outlook.com>
3094223 to
42a11c3
Compare
Fixes #1234
Python bindings return dictionary-type python object for UnknownSchema data.