Skip to content

Bindings: UnknownSchema added data property - #1799

Merged
meshula merged 2 commits into
AcademySoftwareFoundation:mainfrom
natchar:otio_unknownSchema_data
Aug 7, 2026
Merged

Bindings: UnknownSchema added data property#1799
meshula merged 2 commits into
AcademySoftwareFoundation:mainfrom
natchar:otio_unknownSchema_data

Conversation

@natchar

@natchar natchar commented Sep 27, 2024

Copy link
Copy Markdown
Contributor

Fixes #1234

Python bindings return dictionary-type python object for UnknownSchema data.

@linux-foundation-easycla

linux-foundation-easycla Bot commented Sep 27, 2024

Copy link
Copy Markdown

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: natchar / name: Natchar (9f47a35)

@codecov-commenter

codecov-commenter commented Sep 27, 2024

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.25%. Comparing base (0eebd21) to head (42a11c3).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1799      +/-   ##
==========================================
+ Coverage   83.21%   83.25%   +0.03%     
==========================================
  Files         180      180              
  Lines       13465    13479      +14     
  Branches     1253     1253              
==========================================
+ Hits        11205    11222      +17     
+ Misses       2088     2085       -3     
  Partials      172      172              
Flag Coverage Δ
py-unittests 83.25% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/opentimelineio/unknownSchema.h 33.33% <100.00%> (+33.33%) ⬆️
...entimelineio-bindings/otio_serializableObjects.cpp 84.34% <100.00%> (+0.07%) ⬆️
tests/test_unknown_schema.py 92.00% <100.00%> (+3.76%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0eebd21...42a11c3. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jminor

jminor commented Sep 30, 2024

Copy link
Copy Markdown
Collaborator

This looks good to me. Once this lands, then this feature in Raven should be easy to implement: OpenTimelineIO/raven#26

@ssteinbach do you have any concerns with this?

@jminor
jminor requested a review from ssteinbach September 30, 2024 15:58
@jmertic jmertic added the devdays24 Dev Days 2024 PRs/Issues label Sep 30, 2024
Comment thread src/opentimelineio/unknownSchema.h Outdated

@jminor jminor left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summarizing discussion thread: could you alter data() to return a copy of _data?

@natchar
natchar force-pushed the otio_unknownSchema_data branch from a8974b3 to bea1d48 Compare September 25, 2025 16:46
@reinecke
reinecke force-pushed the otio_unknownSchema_data branch from bea1d48 to 9f47a35 Compare November 5, 2025 20:35
@reinecke reinecke modified the milestones: Public Beta 18, 0.19.0 Nov 5, 2025
@natchar
natchar force-pushed the otio_unknownSchema_data branch from 9f47a35 to 3e32272 Compare May 14, 2026 20:16
@natchar
natchar requested review from jminor and meshula May 14, 2026 20:17
@natchar
natchar force-pushed the otio_unknownSchema_data branch from 3e32272 to fbe8c3b Compare May 14, 2026 20:21
@timlehr

timlehr commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

@jminor this should be good to re-review.
@apetrynet can you kick off the Doc build again? Seems like it died randomly.

@apetrynet

Copy link
Copy Markdown
Contributor

@timlehr @natchar
I see this error message on RTD.

Config file validation error Config validation error in build.os. Expected one of (ubuntu-22.04, ubuntu-24.04, ubuntu-26.04, ubuntu-lts-latest), got type str (ubuntu-20.04). Double check the type of the value. A string may be required (e.g. "3.10" instead of 3.10)

Output from log:

git clone --depth 1 https://github.com/AcademySoftwareFoundation/OpenTimelineIO.git .
git fetch origin --force --prune --prune-tags --depth 50 pull/1799/head:external-1799
git checkout --force 4123122
cat .readthedocs.yml

Looks like we need to update the rtd config file. Perhaps in a separate PR?

@apetrynet

Copy link
Copy Markdown
Contributor

I've submitted a PR to unblock this. Sorry about the delay.

@apetrynet

Copy link
Copy Markdown
Contributor

The main branch should be at a good state to continue with this PR.

@natchar
natchar force-pushed the otio_unknownSchema_data branch from 4123122 to 3094223 Compare June 24, 2026 14:06
@timlehr

timlehr commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

@jminor seems like your comment has been adressed. Is this good to be approved?

natchar added 2 commits August 7, 2026 11:47
Signed-off-by: Natchar Ratanasirigulchai <natchar.r@outlook.com>
Signed-off-by: Natchar Ratanasirigulchai <natchar.r@outlook.com>
@meshula
meshula force-pushed the otio_unknownSchema_data branch from 3094223 to 42a11c3 Compare August 7, 2026 18:47
@meshula
meshula merged commit bc5fe2d into AcademySoftwareFoundation:main Aug 7, 2026
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UnknownSchema objects should allow dictionary-like access to data fields

9 participants