forked from lance-format/lance-graph
-
Notifications
You must be signed in to change notification settings - Fork 0
lance-graph-report: CoordSpec::MaskSet, a set coordinate over resident masks #1291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
16 changes: 16 additions & 0 deletions
16
.claude/board/entries/2026-09-25-report-mask-set-coordinate.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| # 2026-09-25 — A SET coordinate for the report substrate: `CoordSpec::MaskSet` | ||
|
|
||
| **Status:** TEST-PINNED · OPEN (one pass per member, not one keyed pass) | ||
|
|
||
| ## What landed | ||
| - `CoordSpec::MaskSet { base, count }`: member `m` is the resident mask `base + m`. It is the coordinate of a many-to-many axis — paperless-ngx's tags, the gap `tesseract-paperless::axes` named ("count per tag is one scalar fold per tag, not one pivot"). | ||
| - A row lands in every member whose mask holds it (zero, one or several), so the dimension's cells do not sum to the selected population. The per-row test oracle (`tests/common`) now places a row in the cartesian product of its per-dimension memberships. | ||
| - Planned as `Provider::MaskPlanes`: each member is one mask plane read in place, always a partition, never the fold key. A missing member mask is `UnknownMask`; `count == 0` is the new `EmptyMaskSet`. | ||
| - `CoordSpec::field()` now returns `Option<FieldId>` (a mask set reads no lane). | ||
|
|
||
| ## Evidence | ||
| - `tests/mask_set.rs` (6): alone, crossed with an ordinal fold key (dense and sparse), under a selection — all against the oracle; per-tag counts equal the (row, tag) membership count and exceed the tagged rows; missing mask refused; empty set refused; explain names the set. The fixture asserts it contains untagged rows and rows with ≥ 2 tags. | ||
| - Disable runs, each red then restored: member filter reading the validity plane (3 tests fail); empty-set guard removed; missing mask read as the validity plane. | ||
|
|
||
| ## Open | ||
| - Cost is one population pass per member (× the other partitions), exactly as before — the win is one plan, one result space and one render, not fewer passes. A keyed multi-membership fold (one pass for all members) would need a mask-RISC aggregation that does not exist. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.