Repository navigation
D-GSO-6 follow-up: derive the selector's new_encounter from revision output #1362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 changes: 39 additions & 0 deletions
39
.claude/board/entries/2026-10-06-selector-revision-wired.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| # 2026-10-06 — D-GSO-6 follow-up: the selector's revision fact is wired | ||
|
|
||
| ## MEASURED | ||
|
|
||
| `crates/cognitive-shader-driver/examples/recipe_selector_probe.rs`, now 12 | ||
| tests (7 new), 5 disable runs red. Builds on D-GSO-6 (#1358) and the Round 6 | ||
| cycle (#1359). | ||
|
|
||
| - `new_encounter` is no longer supplied. It is read from the world: the | ||
| encounter's independent roots minus the horizon's. That equals | ||
| `GadamerRevision`'s `new_independent_roots` with the horizon as ancestry. | ||
| - The `Revision` recipe runs `GadamerRevision::revise`; only | ||
| `delta.resulting` reaches the next state. | ||
| - After one real revision the cycle rests (roots `0b101 → 0b111`). With the | ||
| write dropped it selects `Revision` every step and never rests. | ||
| - An echo (no new root) selects nothing. A held claim gaining its first | ||
| root (`IndependentConfirmation`) selects `Revision` once. | ||
| - Every (policy, stand-in state) start replays to the same path and the | ||
| same final horizon. | ||
|
|
||
| Disable runs, each red: derived fact forced true; derived fact ignored in | ||
| favour of the supplied flag; revise result discarded; roots compared | ||
| against projected claims instead of roots; the bypass flag ignored. The | ||
| roots-vs-claims disable was green until the held-claim case was added. | ||
|
|
||
| ## FINDING | ||
|
|
||
| - **The selector's rest after revision now comes from revision's output.** | ||
| It is no longer a stand-in. | ||
| - **`local_disagreement` cannot be read off the horizon.** | ||
| `unresolved_tension` survives every revision, so a selector reading it | ||
| would interrogate forever. | ||
|
|
||
| ## OPEN | ||
|
|
||
| - `observations_pending`, `frontier_bounded` and `local_disagreement` are | ||
| still stand-ins. The last needs a source that clears: tension new since | ||
| the last interrogation, not tension held. | ||
| - The policy version still covers selection only (§13 digest). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a fresh encounter changes the projection or carries resistance/contradictions but introduces no new independent root, this predicate returns false and
wired_cyclerests without applying the encounter. The addedan_echo_selects_nothingcase demonstrates the problem: it retainsfusion_world()'s changedproposed_claims, resistance, and contradiction, soGadamerRevision::revisewould produceContradictionPreserved, updateprojected_claims, and preserve the tension—not an echo. Track whether the encounter has been processed separately from root novelty so these valid rootless revisions are not silently discarded.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct. A roots-only test dropped rootless revisions, and
an_echo_selects_nothingwas not an echo. Fixed in d82a346f (pushing now):new_encounterholds while revising would still change a horizon mask (projected claims, a root, an inherited root, or a contradiction not yet in the tension), one test per fielddelta.resultingwrites. On all 65 536 worlds of a 2-bit universe it equals whetherrevisechanges those masks. Addeda_rootless_contradiction_is_still_revised(ContradictionPreserved, applied once, then rests) and made the echo test a trueEcho. Restoring the roots-only predicate turns both new tests red.Generated by Claude Code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correction to the reply above: this PR merged before the fix was pushed. The fix landed in #1365 (commit b448ffe).
Generated by Claude Code