Repository navigation
Selector probe: sequence-aware coverage for local_disagreement - #1380
Conversation
present(encounter, seq) refuses a seq that is not greater than the last (the D-GSO-8 rule) and stamps contradiction bits; MooreInterrogation records the covered seq per bit. A tension bit reopens when never covered or when newer evidence arrived, so new evidence on a covered bit reopens the interrogation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MHMvKHLhM6xwRswKY4s6vY
|
Warning Review limit reachedYour organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Next included review available in 42 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. Your 59 included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (4)
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Comment |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: f154b805-4578-4d3e-85c4-c9fb4b53e49b) |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: 1fb09882-a2f8-4c40-94a4-a348f2073322) |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: df12fba262
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Addresses the Codex review on #1380: present() overwrote the single encounter slot, so a second encounter accepted before wired_cycle ran replaced the first while last_seq moved past both. A newer encounter is now refused (Refused::Unprocessed, world unchanged) while the accepted one is still revision_pending. Fixture encounters written without present stay replaceable. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MHMvKHLhM6xwRswKY4s6vY
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: 08fbbd73-5282-4637-b4fd-4cd22695d2b2) |
#1368 left one limit open: coverage was per tension bit, so new evidence on an already-covered bit never reopened the Moore interrogation. This PR closes it with the D-GSO-8 sequence rule from #1366. Everything is in
crates/cognitive-shader-driver/examples/recipe_selector_probe.rs.Change
Presenting an encounter.
present(encounter, seq)is the "do". It returnsRefusedand leaves the world unchanged in two cases:Refused::StaleSeq— theseqis not greater than the last accepted one.Refused::Unprocessed— the encounter accepted before it has not been revised with yet (it is stillrevision_pending). There is one encounter slot, so an accepted encounter is never replaced before it is processed. This addresses the Codex review.An accepted encounter stamps each of its contradiction bits with its
seq.Recording coverage.
MooreInterrogationnow records, per bit, the evidenceseqit covered, alongside the existinginterrogatedmask.When the fact holds.
local_disagreementis true for a tension bit that was never covered, or for one whose newest evidence is newer than its coverage.Measured
29 tests, 4 of them new. The earlier tests are unchanged: an encounter written without
presentcarriesseq0, never reopens a covered bit, and can be replaced.seq, with nothing else in the horizon changing, reopens the interrogation once.revision_pendingstays false, and the newseqis recorded.seq, or an older one, is refused and changes nothing.mainprints the reopen and the refusal:[MooreInterrogation], thenErr(StaleSeq(2)).Disable runs (each red)
seqallowed.seqnot recorded.>=used instead of>.Clippy is clean with and without tests, and fmt is clean.
Open
seq. Verdict arrivals and changes to the candidate space don't yet, so they are not on one durable event chronology.evidence_seqandcovered_seqexist only in this probe, likeinterrogated.Board: the
STATUS_BOARD.mdD-GSO-6 row is updated. New entry.claude/board/entries/2026-10-07-selector-seq-aware-coverage.md; the entries index is regenerated, andSUPERSESSION-INDEX.mdwas regenerated and came out unchanged.🤖 Generated with Claude Code
https://claude.ai/code/session_01MHMvKHLhM6xwRswKY4s6vY