Skip to content

Selector probe: sequence-aware coverage for local_disagreement - #1380

Merged
AdaWorldAPI merged 2 commits into
mainfrom
claude/sharp-bardeen-8nlu1z-r10
Oct 7, 2026
Merged

AdaWorldAPI merged 2 commits into
mainfrom
claude/sharp-bardeen-8nlu1z-r10

Conversation

@AdaWorldAPI

@AdaWorldAPI AdaWorldAPI commented Oct 7, 2026 •

Copy link
Copy Markdown
Owner

#1368 left one limit open: coverage was per tension bit, so new evidence on an already-covered bit never reopened the Moore interrogation. This PR closes it with the D-GSO-8 sequence rule from #1366. Everything is in crates/cognitive-shader-driver/examples/recipe_selector_probe.rs.

Change

  • Presenting an encounter. present(encounter, seq) is the "do". It returns Refused and leaves the world unchanged in two cases:

    • Refused::StaleSeq — the seq is not greater than the last accepted one.
    • Refused::Unprocessed — the encounter accepted before it has not been revised with yet (it is still revision_pending). There is one encounter slot, so an accepted encounter is never replaced before it is processed. This addresses the Codex review.

    An accepted encounter stamps each of its contradiction bits with its seq.

  • Recording coverage. MooreInterrogation now records, per bit, the evidence seq it covered, alongside the existing interrogated mask.

  • When the fact holds. local_disagreement is true for a tension bit that was never covered, or for one whose newest evidence is newer than its coverage.

Measured

29 tests, 4 of them new. The earlier tests are unchanged: an encounter written without present carries seq 0, never reopens a covered bit, and can be replaced.

  • Newer evidence reopens a covered bit. The same contradiction presented again at a newer seq, with nothing else in the horizon changing, reopens the interrogation once. revision_pending stays false, and the new seq is recorded.
  • Stale sequence numbers are refused. Re-presenting a used seq, or an older one, is refused and changes nothing.
  • An unprocessed encounter is not replaced. A second encounter is refused until the cycle has revised with the first; after that it is accepted.
  • Only the right bit reopens. Evidence on one bit does not reopen another.
  • main prints the reopen and the refusal: [MooreInterrogation], then Err(StaleSeq(2)).

Disable runs (each red)

  1. Reusing a seq allowed.
  2. The stale-coverage clause removed.
  3. The covered seq not recorded.
  4. Evidence not stamped.
  5. >= used instead of >.
  6. The unprocessed-encounter refusal removed.
  7. The encounter written before the refusal check. This one stayed green at first, because the refusal test re-presented the encounter that was already current. The test now presents a different encounter, and the disable fails.

Clippy is clean with and without tests, and fmt is clean.

Open

  • Only encounters carry a seq. Verdict arrivals and changes to the candidate space don't yet, so they are not on one durable event chronology.
  • evidence_seq and covered_seq exist only in this probe, like interrogated.

Board: the STATUS_BOARD.md D-GSO-6 row is updated. New entry .claude/board/entries/2026-10-07-selector-seq-aware-coverage.md; the entries index is regenerated, and SUPERSESSION-INDEX.md was regenerated and came out unchanged.

🤖 Generated with Claude Code

https://claude.ai/code/session_01MHMvKHLhM6xwRswKY4s6vY

present(encounter, seq) refuses a seq that is not greater than the last
(the D-GSO-8 rule) and stamps contradiction bits; MooreInterrogation records
the covered seq per bit. A tension bit reopens when never covered or when
newer evidence arrived, so new evidence on a covered bit reopens the
interrogation.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MHMvKHLhM6xwRswKY4s6vY
@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

Next included review available in 42 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available. Your 59 included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: c51aa117-cfda-47e3-87d8-42a44cc2de16
📥 Commits

Reviewing files that changed from the base of the PR and between 3e8fda2 and 413b21e.

📒 Files selected for processing (4)
  • .claude/board/STATUS_BOARD.md
  • .claude/board/entries/2026-10-07-selector-seq-aware-coverage.md
  • .claude/board/entries/README.md
  • crates/cognitive-shader-driver/examples/recipe_selector_probe.rs
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.


Comment @coderabbitai help to get the list of available commands.

@cursor

cursor Bot commented Oct 7, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: f154b805-4578-4d3e-85c4-c9fb4b53e49b)

@AdaWorldAPI
AdaWorldAPI marked this pull request as ready for review October 7, 2026 09:59
@cursor

cursor Bot commented Oct 7, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: 1fb09882-a2f8-4c40-94a4-a348f2073322)

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-07T10:01:15.124255Z df12fba Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: df12fba262

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/cognitive-shader-driver/examples/recipe_selector_probe.rs
Addresses the Codex review on #1380: present() overwrote the single
encounter slot, so a second encounter accepted before wired_cycle ran
replaced the first while last_seq moved past both. A newer encounter is
now refused (Refused::Unprocessed, world unchanged) while the accepted one
is still revision_pending. Fixture encounters written without present
stay replaceable.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MHMvKHLhM6xwRswKY4s6vY
@cursor

cursor Bot commented Oct 7, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: 08fbbd73-5282-4637-b4fd-4cd22695d2b2)

@AdaWorldAPI
AdaWorldAPI merged commit 1c91fa4 into main Oct 7, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants