Skip to content

rustfmt: lane-fold and arm-discovery (unblocks downstream fmt gates) - #1451

Merged
AdaWorldAPI merged 1 commit into
mainfrom
ccr-edc85bd9-89tiwe
Oct 10, 2026
Merged

AdaWorldAPI merged 1 commit into
mainfrom
ccr-edc85bd9-89tiwe

Conversation

@AdaWorldAPI

Copy link
Copy Markdown
Owner

This only reformats code, in 13 files in lance-graph-lane-fold and lance-graph-arm-discovery. These files on main weren't rustfmt-clean; they arrived with #1381.

Why it matters downstream

q2's CI checks out lance-graph as a sibling and runs cargo fmt --all -- --check. --all also reaches these sources, so q2's Rustfmt gate fails on lance-graph's formatting, not on q2's own code. q2's test-suite.yml documents that a sibling has to be rustfmt-clean for this reason. It's currently failing AdaWorldAPI/q2#156.

Verified

  • I formatted with the pinned 1.99.0 rustfmt. There are no code changes.
  • cargo check --all-targets passes for both crates (arm-discovery is checked through its own manifest).
  • cargo fmt -- --check passes for both crates.
  • With this branch checked out as q2's sibling, q2's cargo fmt --all -- --check exits 0.

STATUS: done | OUTCOME: 13 files rustfmt'd, behaviour unchanged | OPEN: none

🤖 Generated with Claude Code

https://claude.ai/code/session_017YPZhKpSxN7eSxk7VH2vzB


Generated by Claude Code

Format-only. 13 files in lance-graph-lane-fold and lance-graph-arm-discovery
were not rustfmt-clean on main (landed via #1381). q2's CI runs
`cargo fmt --all -- --check` with lance-graph checked out as a sibling, and
`--all` reaches these sources, so its Rustfmt gate fails on them (seen on
AdaWorldAPI/q2#156).

Formatted with the pinned 1.99.0 rustfmt; no code changes. Both crates
`cargo check --all-targets` and `cargo fmt -- --check` clean.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017YPZhKpSxN7eSxk7VH2vzB
@coderabbitai

coderabbitai Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 04bfa7f4-e9c8-4545-ae8b-8ca5be3dc205

📥 Commits

Reviewing files that changed from the base of the PR and between 488571c and e11bcda.


📒 Files selected for processing (13)
  • crates/lance-graph-arm-discovery/src/aerial/codebook.rs
  • crates/lance-graph-arm-discovery/src/aerial/extract.rs
  • crates/lance-graph-arm-discovery/src/aerial/mod.rs
  • crates/lance-graph-arm-discovery/src/aerial/ontology.rs
  • crates/lance-graph-arm-discovery/src/bitset.rs
  • crates/lance-graph-arm-discovery/src/rule.rs
  • crates/lance-graph-arm-discovery/src/simd.rs
  • crates/lance-graph-arm-discovery/src/translator.rs
  • crates/lance-graph-arm-discovery/tests/wikidata_landing.rs
  • crates/lance-graph-lane-fold/src/clifford_fold.rs
  • crates/lance-graph-lane-fold/src/lib.rs
  • crates/lance-graph-lane-fold/src/query.rs
  • crates/lance-graph-lane-fold/src/stars.rs

 _____________________________________________________________________________________________
< Use the power of command shells. Use the shell when graphical user interfaces don't cut it. >
 ---------------------------------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.


Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-10T14:11:23.313324Z e11bcda Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@AdaWorldAPI
AdaWorldAPI merged commit fe171b1 into main Oct 10, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants