Repository navigation
rustfmt: lane-fold and arm-discovery (unblocks downstream fmt gates) - #1451
Merged
Merged
Conversation
Format-only. 13 files in lance-graph-lane-fold and lance-graph-arm-discovery were not rustfmt-clean on main (landed via #1381). q2's CI runs `cargo fmt --all -- --check` with lance-graph checked out as a sibling, and `--all` reaches these sources, so its Rustfmt gate fails on them (seen on AdaWorldAPI/q2#156). Formatted with the pinned 1.99.0 rustfmt; no code changes. Both crates `cargo check --all-targets` and `cargo fmt -- --check` clean. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017YPZhKpSxN7eSxk7VH2vzB
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (13)
✨ Finishing Touches
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Comment |
AdaWorldAPI
marked this pull request as ready for review
October 10, 2026 14:10
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This only reformats code, in 13 files in
lance-graph-lane-foldandlance-graph-arm-discovery. These files onmainweren't rustfmt-clean; they arrived with #1381.Why it matters downstream
q2's CI checks out lance-graph as a sibling and runs
cargo fmt --all -- --check.--allalso reaches these sources, so q2's Rustfmt gate fails on lance-graph's formatting, not on q2's own code. q2'stest-suite.ymldocuments that a sibling has to be rustfmt-clean for this reason. It's currently failing AdaWorldAPI/q2#156.Verified
cargo check --all-targetspasses for both crates (arm-discovery is checked through its own manifest).cargo fmt -- --checkpasses for both crates.cargo fmt --all -- --checkexits 0.STATUS: done | OUTCOME: 13 files rustfmt'd, behaviour unchanged | OPEN: none🤖 Generated with Claude Code
https://claude.ai/code/session_017YPZhKpSxN7eSxk7VH2vzB
Generated by Claude Code