Skip to content

cockpit-server: object_store 0.14 to follow lance 12 - #155

Merged
AdaWorldAPI merged 1 commit into
mainfrom
claude/llvm-codegen-polyfill-gni3cw
Sep 25, 2026
Merged

AdaWorldAPI merged 1 commit into
mainfrom
claude/llvm-codegen-polyfill-gni3cw

Conversation

@AdaWorldAPI

Copy link
Copy Markdown
Owner

Follow-up to #154, which bumped lance to 12.

What changed. lance 12 moved to object_store 0.14. cockpit-server's direct object_store pin was still 0.13.2, and its comment claimed it matched the version lance brings in. This PR moves the pin to 0.14 and corrects the comment. Cargo.lock now carries 0.14.2 for lance and for the S3 hydrators. 0.13.2 stays in the graph for datafusion 54.

Verification. I ran cargo +1.98.1 check -p cockpit-server --all-targets. body_bake_v4.rs and osm_slab_hydrate.rs, the only object_store users, compile unchanged against 0.14. The command still fails: every remaining error is in osint_gotham.rs, which reads EdgeFacet.in_family / out_family. lance-graph's contract removed those fields on 2026-09-17, so this error is already on main and needs its own fix.

🤖 Generated with Claude Code

https://claude.ai/code/session_019HnekoM1EidTwQLS3oFVFm


Generated by Claude Code

lance 12 moved to object_store 0.14 (datafusion 54 still carries 0.13
alongside it). The direct dep's own comment claimed it matched the version
lance brings in; after the lance 12 bump that stopped being true.
body_bake_v4.rs and osm_slab_hydrate.rs (the only users) compile against
0.14 unchanged. The remaining cockpit-server errors are all in
osint_gotham.rs (EdgeFacet.in_family/out_family, removed from
lance-graph's contract 2026-09-17) and predate this change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019HnekoM1EidTwQLS3oFVFm
@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: db462284-c17e-44ec-aa78-37dda2124d2e

📥 Commits

Reviewing files that changed from the base of the PR and between 31d71c4 and 285abc4.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • crates/cockpit-server/Cargo.toml
 ____________________________________________________________________________________________________________________________________________
< Organize teams around functionality. Don't separate designers from coders, testers from data modelers. Build teams the way you build code. >
 --------------------------------------------------------------------------------------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ

Comment @coderabbitai help to get the list of available commands.

@cursor

cursor Bot commented Sep 25, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_204d2b2d-7dbe-4a56-8e06-b509a69704f4)

@AdaWorldAPI
AdaWorldAPI marked this pull request as ready for review September 25, 2026 02:31
@AdaWorldAPI
AdaWorldAPI merged commit 138ef5a into main Sep 25, 2026
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants