cockpit-server: object_store 0.14 to follow lance 12 - #155
Merged
Merged
Conversation
lance 12 moved to object_store 0.14 (datafusion 54 still carries 0.13 alongside it). The direct dep's own comment claimed it matched the version lance brings in; after the lance 12 bump that stopped being true. body_bake_v4.rs and osm_slab_hydrate.rs (the only users) compile against 0.14 unchanged. The remaining cockpit-server errors are all in osint_gotham.rs (EdgeFacet.in_family/out_family, removed from lance-graph's contract 2026-09-17) and predate this change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019HnekoM1EidTwQLS3oFVFm
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Comment |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_204d2b2d-7dbe-4a56-8e06-b509a69704f4) |
AdaWorldAPI
marked this pull request as ready for review
September 25, 2026 02:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #154, which bumped lance to 12.
What changed. lance 12 moved to
object_store0.14. cockpit-server's directobject_storepin was still0.13.2, and its comment claimed it matched the version lance brings in. This PR moves the pin to0.14and corrects the comment.Cargo.locknow carries 0.14.2 for lance and for the S3 hydrators. 0.13.2 stays in the graph for datafusion 54.Verification. I ran
cargo +1.98.1 check -p cockpit-server --all-targets.body_bake_v4.rsandosm_slab_hydrate.rs, the onlyobject_storeusers, compile unchanged against 0.14. The command still fails: every remaining error is inosint_gotham.rs, which readsEdgeFacet.in_family/out_family. lance-graph's contract removed those fields on 2026-09-17, so this error is already onmainand needs its own fix.🤖 Generated with Claude Code
https://claude.ai/code/session_019HnekoM1EidTwQLS3oFVFm
Generated by Claude Code