Repository navigation
cockpit-server: float lance as 13.*, not =13.0.0 - #157
Conversation
PR #156 carried the old `=12.0.0` forward as `=13.0.0`. The lance-graph pin rule (2026-09-18) is to float the patch within the major and never pin `.0.0`: our requirement may only be equal to or wider than what lancedb demands, never narrower. Cargo.lock is unchanged (`cargo metadata --locked` passes; still resolves lance 13.0.0). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017YPZhKpSxN7eSxk7VH2vzB
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to No actionable issue is established for this dependency-range change. Normal validation can proceed before merge. Pre-merge checks |
 |
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly and concisely describes the main change: allowing the lance dependency to use the 13.* version range instead of the exact 13.0.0 version. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.
A rabbit checks the version line
And finds a wider range to sign
Thirteen-point-oh may now advance
The manifest gives Lance more chance
Then hops away to nibble thyme
Comment @coderabbitai help to get the list of available commands.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
2 participants
#156 carried the old
lance = "=12.0.0"pin forward as=13.0.0. The lance-graph pin rule (2026-09-18) is to float the patch within the major (13.*) and never write an exact.0.0pin. An exact pin can only be narrower than what lancedb itself requires, never wider, so it buys nothing and deadlocks the build as soon as lancedb's transitive requirement moves by a patch.crates/cockpit-server/Cargo.toml:lance = "=13.0.0"→lance = "13.*", with a one-line comment giving the reason.Cargo.lockis unchanged:cargo metadata --lockedpasses, and it still resolves to lance 13.0.0.I also checked the rest of #156 for other pins and links: it added no symbolic links (the four in q2 and lance-graph predate it) and no new git
rev/branchpins.🤖 Generated with Claude Code
https://claude.ai/code/session_017YPZhKpSxN7eSxk7VH2vzB
Generated by Claude Code
Summary by CodeRabbit