Skip to content

[management] Code generation: update services and models - #405

Open
AdyenAutomationBot wants to merge 1 commit into
mainfrom
sdk-automation/management
Open

AdyenAutomationBot wants to merge 1 commit into
mainfrom
sdk-automation/management

Conversation

@AdyenAutomationBot

@AdyenAutomationBot AdyenAutomationBot commented Sep 23, 2026 •

Copy link
Copy Markdown
Collaborator

This PR contains the automated changes for the management service.

Adyen/adyen-openapi@2c1f3ab

The commit history of this PR reflects the adyen-openapi commits that have been applied.

@AdyenAutomationBot
AdyenAutomationBot requested a review from a team as a code owner September 23, 2026 12:27

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several new management APIs, including ClientCertificatesCompanyLevelApi and various TerminalThemes APIs across company, merchant, store, and terminal levels. The review feedback correctly identifies that several POST methods for adding and editing terminal theme assets at both the company and merchant levels are missing the required 'request' parameter in their signatures, which prevents users from providing the necessary payload.

Comment on lines +16 to +21
def add_terminal_theme_asset_for_company(company_id, id, headers: {}, query_params: {})
endpoint = build_endpoint('/companies/{companyId}/terminalThemes/{id}/assets', company_id, id)
endpoint += create_query_string(query_params)
action = { method: 'post', url: endpoint }
@client.call_adyen_api(@service, action, {}, headers, @version)
end

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The add_terminal_theme_asset_for_company method is missing the request parameter in its signature. Since this is a POST request to add an asset, a request body containing the asset payload is required. Currently, an empty hash {} is hardcoded as the request payload in the call_adyen_api call, making it impossible for users to upload or specify the asset.

def add_terminal_theme_asset_for_company(request, company_id, id, headers: {}, query_params: {})
      endpoint = build_endpoint('/companies/{companyId}/terminalThemes/{id}/assets', company_id, id)
      endpoint += create_query_string(query_params)
      action = { method: 'post', url: endpoint }
      @client.call_adyen_api(@service, action, request, headers, @version)
    end

Comment on lines +56 to +61
def edit_terminal_theme_asset_for_company(company_id, id, headers: {}, query_params: {})
endpoint = build_endpoint('/companies/{companyId}/terminalThemes/{id}/assets/replace', company_id, id)
endpoint += create_query_string(query_params)
action = { method: 'post', url: endpoint }
@client.call_adyen_api(@service, action, {}, headers, @version)
end

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The edit_terminal_theme_asset_for_company method is missing the request parameter in its signature. Since this is a POST request to replace/edit an asset, a request body containing the new asset payload is required. Currently, an empty hash {} is hardcoded as the request payload in the call_adyen_api call, making it impossible for users to upload or specify the asset.

def edit_terminal_theme_asset_for_company(request, company_id, id, headers: {}, query_params: {})
      endpoint = build_endpoint('/companies/{companyId}/terminalThemes/{id}/assets/replace', company_id, id)
      endpoint += create_query_string(query_params)
      action = { method: 'post', url: endpoint }
      @client.call_adyen_api(@service, action, request, headers, @version)
    end

Comment on lines +16 to +21
def add_terminal_theme_asset_for_merchant(merchant_id, id, headers: {}, query_params: {})
endpoint = build_endpoint('/merchants/{merchantId}/terminalThemes/{id}/assets', merchant_id, id)
endpoint += create_query_string(query_params)
action = { method: 'post', url: endpoint }
@client.call_adyen_api(@service, action, {}, headers, @version)
end

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The add_terminal_theme_asset_for_merchant method is missing the request parameter in its signature. Since this is a POST request to add an asset, a request body containing the asset payload is required. Currently, an empty hash {} is hardcoded as the request payload in the call_adyen_api call, making it impossible for users to upload or specify the asset.

def add_terminal_theme_asset_for_merchant(request, merchant_id, id, headers: {}, query_params: {})
      endpoint = build_endpoint('/merchants/{merchantId}/terminalThemes/{id}/assets', merchant_id, id)
      endpoint += create_query_string(query_params)
      action = { method: 'post', url: endpoint }
      @client.call_adyen_api(@service, action, request, headers, @version)
    end

Comment on lines +56 to +61
def edit_terminal_theme_asset_for_merchant(merchant_id, id, headers: {}, query_params: {})
endpoint = build_endpoint('/merchants/{merchantId}/terminalThemes/{id}/assets/replace', merchant_id, id)
endpoint += create_query_string(query_params)
action = { method: 'post', url: endpoint }
@client.call_adyen_api(@service, action, {}, headers, @version)
end

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The edit_terminal_theme_asset_for_merchant method is missing the request parameter in its signature. Since this is a POST request to replace/edit an asset, a request body containing the new asset payload is required. Currently, an empty hash {} is hardcoded as the request payload in the call_adyen_api call, making it impossible for users to upload or specify the asset.

def edit_terminal_theme_asset_for_merchant(request, merchant_id, id, headers: {}, query_params: {})
      endpoint = build_endpoint('/merchants/{merchantId}/terminalThemes/{id}/assets/replace', merchant_id, id)
      endpoint += create_query_string(query_params)
      action = { method: 'post', url: endpoint }
      @client.call_adyen_api(@service, action, request, headers, @version)
    end

@AdyenAutomationBot
AdyenAutomationBot force-pushed the sdk-automation/management branch 5 times, most recently from cd3cd43 to 0768be0 Compare September 28, 2026 10:17
@AdyenAutomationBot
AdyenAutomationBot force-pushed the sdk-automation/management branch 3 times, most recently from cd171de to 5dea9b9 Compare October 1, 2026 14:41
@AdyenAutomationBot
AdyenAutomationBot force-pushed the sdk-automation/management branch 2 times, most recently from ce9798f to 5c692cf Compare October 8, 2026 14:22
@AdyenAutomationBot
AdyenAutomationBot force-pushed the sdk-automation/management branch from 5c692cf to 353f39a Compare October 15, 2026 13:05
@AdyenAutomationBot
AdyenAutomationBot force-pushed the sdk-automation/management branch 14 times, most recently from bb0e219 to 3d20277 Compare October 22, 2026 13:33
@AdyenAutomationBot
AdyenAutomationBot force-pushed the sdk-automation/management branch from 3d20277 to 27c9097 Compare October 22, 2026 14:18
@sonarqubecloud

Copy link
Copy Markdown

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants