Repository navigation
[management] Code generation: update services and models - #405
AdyenAutomationBot wants to merge 1 commit into
Conversation
5eec5de to
d4c1768
Compare
There was a problem hiding this comment.
Code Review
This pull request introduces several new management APIs, including ClientCertificatesCompanyLevelApi and various TerminalThemes APIs across company, merchant, store, and terminal levels. The review feedback correctly identifies that several POST methods for adding and editing terminal theme assets at both the company and merchant levels are missing the required 'request' parameter in their signatures, which prevents users from providing the necessary payload.
| def add_terminal_theme_asset_for_company(company_id, id, headers: {}, query_params: {}) | ||
| endpoint = build_endpoint('/companies/{companyId}/terminalThemes/{id}/assets', company_id, id) | ||
| endpoint += create_query_string(query_params) | ||
| action = { method: 'post', url: endpoint } | ||
| @client.call_adyen_api(@service, action, {}, headers, @version) | ||
| end |
There was a problem hiding this comment.
The add_terminal_theme_asset_for_company method is missing the request parameter in its signature. Since this is a POST request to add an asset, a request body containing the asset payload is required. Currently, an empty hash {} is hardcoded as the request payload in the call_adyen_api call, making it impossible for users to upload or specify the asset.
def add_terminal_theme_asset_for_company(request, company_id, id, headers: {}, query_params: {})
endpoint = build_endpoint('/companies/{companyId}/terminalThemes/{id}/assets', company_id, id)
endpoint += create_query_string(query_params)
action = { method: 'post', url: endpoint }
@client.call_adyen_api(@service, action, request, headers, @version)
end| def edit_terminal_theme_asset_for_company(company_id, id, headers: {}, query_params: {}) | ||
| endpoint = build_endpoint('/companies/{companyId}/terminalThemes/{id}/assets/replace', company_id, id) | ||
| endpoint += create_query_string(query_params) | ||
| action = { method: 'post', url: endpoint } | ||
| @client.call_adyen_api(@service, action, {}, headers, @version) | ||
| end |
There was a problem hiding this comment.
The edit_terminal_theme_asset_for_company method is missing the request parameter in its signature. Since this is a POST request to replace/edit an asset, a request body containing the new asset payload is required. Currently, an empty hash {} is hardcoded as the request payload in the call_adyen_api call, making it impossible for users to upload or specify the asset.
def edit_terminal_theme_asset_for_company(request, company_id, id, headers: {}, query_params: {})
endpoint = build_endpoint('/companies/{companyId}/terminalThemes/{id}/assets/replace', company_id, id)
endpoint += create_query_string(query_params)
action = { method: 'post', url: endpoint }
@client.call_adyen_api(@service, action, request, headers, @version)
end| def add_terminal_theme_asset_for_merchant(merchant_id, id, headers: {}, query_params: {}) | ||
| endpoint = build_endpoint('/merchants/{merchantId}/terminalThemes/{id}/assets', merchant_id, id) | ||
| endpoint += create_query_string(query_params) | ||
| action = { method: 'post', url: endpoint } | ||
| @client.call_adyen_api(@service, action, {}, headers, @version) | ||
| end |
There was a problem hiding this comment.
The add_terminal_theme_asset_for_merchant method is missing the request parameter in its signature. Since this is a POST request to add an asset, a request body containing the asset payload is required. Currently, an empty hash {} is hardcoded as the request payload in the call_adyen_api call, making it impossible for users to upload or specify the asset.
def add_terminal_theme_asset_for_merchant(request, merchant_id, id, headers: {}, query_params: {})
endpoint = build_endpoint('/merchants/{merchantId}/terminalThemes/{id}/assets', merchant_id, id)
endpoint += create_query_string(query_params)
action = { method: 'post', url: endpoint }
@client.call_adyen_api(@service, action, request, headers, @version)
end| def edit_terminal_theme_asset_for_merchant(merchant_id, id, headers: {}, query_params: {}) | ||
| endpoint = build_endpoint('/merchants/{merchantId}/terminalThemes/{id}/assets/replace', merchant_id, id) | ||
| endpoint += create_query_string(query_params) | ||
| action = { method: 'post', url: endpoint } | ||
| @client.call_adyen_api(@service, action, {}, headers, @version) | ||
| end |
There was a problem hiding this comment.
The edit_terminal_theme_asset_for_merchant method is missing the request parameter in its signature. Since this is a POST request to replace/edit an asset, a request body containing the new asset payload is required. Currently, an empty hash {} is hardcoded as the request payload in the call_adyen_api call, making it impossible for users to upload or specify the asset.
def edit_terminal_theme_asset_for_merchant(request, merchant_id, id, headers: {}, query_params: {})
endpoint = build_endpoint('/merchants/{merchantId}/terminalThemes/{id}/assets/replace', merchant_id, id)
endpoint += create_query_string(query_params)
action = { method: 'post', url: endpoint }
@client.call_adyen_api(@service, action, request, headers, @version)
endcd3cd43 to
0768be0
Compare
cd171de to
5dea9b9
Compare
ce9798f to
5c692cf
Compare
5c692cf to
353f39a
Compare
bb0e219 to
3d20277
Compare
3d20277 to
27c9097
Compare
|



This PR contains the automated changes for the
managementservice.Adyen/adyen-openapi@2c1f3ab
The commit history of this PR reflects the
adyen-openapicommits that have been applied.