Repository navigation
[checkout] Code generation: update services and models - #408
AdyenAutomationBot wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds two new endpoints, calculate_tax and verify_shopper_tax_identification, to the UtilityApi class in the Checkout service, along with updating the SDK generation log. The review feedback points out that both of these new methods lack corresponding unit tests in spec/checkout_spec.rb and requests that tests be added following the existing codebase conventions.
| end | ||
|
|
||
| # Calculate the tax for a transaction. | ||
| def calculate_tax(request, headers: {}) |
There was a problem hiding this comment.
The new calculate_tax method is added without any corresponding unit tests in spec/checkout_spec.rb. To ensure the endpoint is correctly constructed and the request is properly forwarded, please add a unit test. Follow the existing codebase conventions in tests, such as asserting both be_a Adyen::HashWithAccessors and be_a_kind_of Hash for response hashes.
References
- Follow existing codebase conventions in tests, such as asserting both
be_a Adyen::HashWithAccessorsandbe_a_kind_of Hashfor response hashes, even if they seem redundant.
| end | ||
|
|
||
| # Verify the shopper's tax identification. | ||
| def verify_shopper_tax_identification(request, headers: {}) |
There was a problem hiding this comment.
The new verify_shopper_tax_identification method is added without any corresponding unit tests in spec/checkout_spec.rb. Please add a unit test to verify its behavior, following the existing codebase conventions in tests (asserting both be_a Adyen::HashWithAccessors and be_a_kind_of Hash for response hashes).
References
- Follow existing codebase conventions in tests, such as asserting both
be_a Adyen::HashWithAccessorsandbe_a_kind_of Hashfor response hashes, even if they seem redundant.
9a0d7bb to
aa8184e
Compare
aa8184e to
397d77d
Compare
|
This PR contains the automated changes for the
checkoutservice.Adyen/adyen-openapi@2c1f3ab
The commit history of this PR reflects the
adyen-openapicommits that have been applied.