Skip to content

fix(selection-button-group): sync controlled value/values when set to… - #494

Merged
roblevintennis merged 1 commit into
masterfrom
issue-493/VueSelectionButtonGroup-not-updated
Jun 30, 2026
Merged

roblevintennis merged 1 commit into
masterfrom
issue-493/VueSelectionButtonGroup-not-updated

Conversation

@roblevintennis

@roblevintennis roblevintennis commented Jun 30, 2026 •

Copy link
Copy Markdown
Contributor

fix(selection-button-group): sync controlled value/values when set to empty

Fixes #493

Docs page is in Vue so added an example that shows the fix:

  1. Select some buttons:
image
  1. Clear programmatically:
image

Checklist

  • Bug fix or new feature?
  • Tests passing?
  • Docs updated? (if needed - see [v2/site/docs]

… empty

Use  as the sole uncontrolled sentinel instead of falsy
checks, so consumers can clear a controlled selection (e.g. )
without falling back to stale internal state.

Fixes #493
@netlify

netlify Bot commented Jun 30, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for agnosticui-demo-react ready!

Name Link
🔨 Latest commit 87eb1c0
🔍 Latest deploy log https://app.netlify.com/projects/agnosticui-demo-react/deploys/6a43e5a35844040008211298
😎 Deploy Preview https://deploy-preview-494--agnosticui-demo-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Jun 30, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for agnosticui-demo-lit ready!

Name Link
🔨 Latest commit 87eb1c0
🔍 Latest deploy log https://app.netlify.com/projects/agnosticui-demo-lit/deploys/6a43e5a30292eb0008362bec
😎 Deploy Preview https://deploy-preview-494--agnosticui-demo-lit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Jun 30, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for agnosticui-demo-vue ready!

Name Link
🔨 Latest commit 87eb1c0
🔍 Latest deploy log https://app.netlify.com/projects/agnosticui-demo-vue/deploys/6a43e5a39af2680008074740
😎 Deploy Preview https://deploy-preview-494--agnosticui-demo-vue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@roblevintennis roblevintennis self-assigned this Jun 30, 2026
@roblevintennis
roblevintennis merged commit a9cbdb9 into master Jun 30, 2026
15 of 17 checks passed
@roblevintennis

Copy link
Copy Markdown
Contributor Author

It seems the Playwright smoke tests are hanging on installing Playwright (Lit and React only). Going to merge as this isn't related to fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VueSelectionButtonGroup not updated when values change

1 participant