Repository navigation
Conversation
Reported externally: the English AgoraAudioLocalReason page is missing enum
value descriptions the Chinese page has.
The cause is a vocabulary mismatch. The corpus spells macOS "mac" -- 1,962
uses against a single "macos" -- but the build is invoked with
--platform_tag macos, and nothing mapped one to the other. So every element
tagged for macOS was dropped from the macOS build, the one place it belongs.
<plentry props="cpp mac unreal bp unity flutter electron cs">
7: (Windows and macOS only) No local audio playback device...
That plentry is removed when building macos, which is why the macOS page
documents 5 of 9 enum values while iOS documents 7.
This predates the recent @props work: the previous implementation tested
whether the platform appeared as a substring of props, and "macos" is not a
substring of "cpp mac unreal". The group rewrite in #4021 kept the blind spot
by listing macos without mac.
Scope, across en-US/dita/RTC-NG/API:
elements tagged mac that the macOS build drops 1,961
files affected 1,272
Not only prose -- props="ios mac" also carries Objective-C prototypes, so the
macOS reference has been losing method signatures too.
Regenerating the templates:
macos 296 of 932 entries change; documentation grows
665,170 -> 718,955 characters (+53,785)
enum_localaudiostreamreason: 5 -> 7 documented values
ios, unity, flutter byte-identical
Add tests for the mapping, including that mac does not widen any other
platform and that a group token never matches a --platform_tag directly.
Confirmed they fail with the entry removed.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported externally: the English
AgoraAudioLocalReasonpage is missing enum value descriptions that the Chinese page has.Cause: a vocabulary mismatch
The corpus spells macOS
mac— 1,962 uses against a singlemacos— but the build is invoked with--platform_tag macos, and nothing mapped one to the other. So every element tagged for macOS was dropped from the macOS build, the one place it belongs.That
plentryis removed when buildingmacos, which is why the macOS page documents 5 of 9 enum values while iOS documents 7.This predates the recent
@propswork. The previous implementation tested whether the platform appeared as a substring of props, andmacosis not a substring ofcpp mac unreal. The group rewrite in #4021 kept the blind spot by listingmacoswithoutmac.Scope — far wider than the report
macthe macOS build dropsNot only prose.
props="ios mac"also carries Objective-C prototypes, so the macOS reference has been losing method signatures:The fix
One entry in
PLATFORM_GROUPS:Verification
enum_localaudiostreamreason5 → 7 documented valuesTests added for the mapping, that
macdoesn't widen any other platform, and that a group token never matches a--platform_tagdirectly. Confirmed they fail with the entry removed.Please confirm the convention
I'm treating
macas meaning macOS, which the content strongly supports —(Windows and macOS only)sits onprops='cpp mac …'. Ifmacever carried a narrower meaning, this would pull in content that was deliberately excluded. One line either way, so cheap to correct if I've read it wrong.🤖 Generated with Claude Code