Repository navigation
Preserve link style when wrapping converted documents - #457
Open
Hugohong258 wants to merge 1 commit into
Open
Hugohong258 wants to merge 1 commit into
Hugohong258 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
wrap_links=Falseand a nonzero body width, the firsthandle()call renders inline links butoptwrap()then changesinline_linkstoFalse. A later call on the same converter unexpectedly emits reference links. Remove that post-conversion configuration mutation and the documentation's outdated implication that disabling wrapping selects reference links. Existing first-call output remains unchanged.This is a link-style instance of the reuse problems in #375; #453 separately addresses emphasis spacing. Six regression cases cover three widths and both link styles; two fail before the fix. The full suite passes 202 tests on Windows/Python 3.12.3. Black, isort, Flake8 and strict mypy 1.18.2 (configured Python 3.9 target) pass. Black emits its Python 3.13 target warning on this Python 3.12 host, and the suite retains three existing pytest deprecation warnings; other interpreters were not tested.