fix: denormal flush of inputs - #1350
Merged
Merged
Conversation
Member
|
Uhm, I forgot about this one. Wasn't this correct? |
Contributor
Author
|
Re-opening this, please take a look at the reasoning below Nuno. Here's an example that I believe alive should reject-- our master branch accepts it. define i1 @src() denormal_fpenv(ieee|positivezero) {
%r = fcmp oeq float 0x380FFFFFC0000000, 0.0
ret i1 %r
}
define i1 @tgt() denormal_fpenv(ieee|positivezero) {
ret i1 false
}Here's the chain of reasoning: 0x380FFFFFC0000000 comes out to be the largest float denormal. LangRef says: The fcmp clearly has an input denormal value, so the interpretation of this seems completely clear-- this can be folded to true, but not to false. |
Member
|
Ok, I traced down the issue. There was a change in LangRef when the input/output flushing modes were split. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this fixes more false alarms seen while running
riscv-tvon the LLVM test suite -- no fuzzer involved, so far!the change here is from LangRef: input flushing is mandatory, not optional