Skip to content

llvm2alive: skip string attributes in handleParamAttrs #1352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nunoplopes merged 1 commit into from
Sep 17, 2026
Merged

llvm2alive: skip string attributes in handleParamAttrs #1352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions llvm_util/llvm2alive.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1574,6 +1574,10 @@ class llvm2alive_ : public llvm::InstVisitor<llvm2alive_, unique_ptr<Instr>> {
Value **val, bool is_callsite) {
bool precise = true;
for (const llvm::Attribute &llvmattr : aset) {
if (!llvmattr.isEnumAttribute() && !llvmattr.isIntAttribute() &&
!llvmattr.isTypeAttribute())
continue;

switch (llvmattr.getKindAsEnum()) {
case llvm::Attribute::InReg:
attrs.set(ParamAttrs::InReg);
Expand Down
16 changes: 16 additions & 0 deletions tests/alive-tv/attrs/string-param-attr.srctgt.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
; string attributes are legal on parameters (LLVM-C frontends emit them as a
; fallback when LLVMGetEnumAttributeKindForName returns 0). handleParamAttrs
; used to call getKindAsEnum() on them, which asserts.
define i32 @src(ptr "foo"="bar" %p) {
%v = load i32, ptr %p
call void @g(ptr "baz"="qux" %p)
ret i32 %v
}

define i32 @tgt(ptr "foo"="bar" %p) {
%v = load i32, ptr %p
call void @g(ptr "baz"="qux" %p)
ret i32 %v
}

declare void @g(ptr)