Skip to content

fix: make sure that multiple CHECK-NOT lines are all checked #1355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nunoplopes merged 1 commit into from
Sep 21, 2026
Merged

fix: make sure that multiple CHECK-NOT lines are all checked #1355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions tests/lit/lit/formats/alive2test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,9 +128,10 @@ def execute(self, test, litConfig):
if output.find(chk.strip()) == -1:
return lit.Test.FAIL, output

chk_not = self.regex_check_not.search(input)
if chk_not != None and output.find(chk_not.group(1).strip()) != -1:
return lit.Test.FAIL, output
chk_not = self.regex_check_not.findall(input)
for chk in chk_not:
if output.find(chk.strip()) != -1:
return lit.Test.FAIL, output

if clang_tv and exitCode != 0:
# clang tv should not exit with non-zero even if validation fails.
Expand All @@ -139,7 +140,7 @@ def execute(self, test, litConfig):

expect_err = self.regex_errs.search(input)
if expect_err is None and xfail is None and len(chks) == 0 and \
chk_not is None:
len(chk_not) == 0:
# If there's no other test, correctness of the transformation should be
# checked.
if exitCode == 0 and output.find(ok_string) != -1 and \
Expand Down
Loading