Fix readKey 未指定時に read/getprop が TypeError になる問題 - #6
Open
masaru87 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
read()(ambient.py:55)とgetprop()(同 81)が readKey の有無をhasattr(self, 'readKey')で判定していますが、__init__はself.readKey = readKey(デフォルトNone)を常に設定するため、この条件は常に True です。その結果、readKey を渡さずに
Ambient(channelId, writeKey)を生成した場合(公開チャンネルの読み取りなど、readKey が不要な使い方)、'readKey=' + self.readKeyが'readKey=' + NoneとなりTypeError: can only concatenate str (not "NoneType") to strで失敗します。Node 版(ambient-nodejs-lib)は同じ箇所を
if (this.readKey != null)で判定しており、そちらに合わせてif self.readKey is not None:に修正しました。readKey を指定した場合の挙動は従来どおりです(URL にreadKey=...が付与されます)。