Fix Redirect responses with background tasks - #921
Open
tunglambk wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #728
Proposed Changes
Normalize objects implementing
__response__when they are returned inside atuple, not only when they are the entire route result. When that produces a
Starlette response, attach any tuple-provided background tasks while preserving
an existing response background task.
Previously,
(Redirect("/"), BackgroundTask(...))skipped the redirect's__response__conversion. FastHTML rendered theRedirectobject as HTML andreturned 200 instead of 303.
Types of changes
Checklist
Additional Information
Validated the regression for standard and HTMX redirects, including task
execution and composition with an existing response background task. The
existing
tests/test_toaster.pyscript passes. The core notebook executes thenew regression successfully, then later stops at the unrelated existing
into()default-title assertion with the latest resolved dependencies.