Repository navigation
feat: OLLAMA_* settings for an existing Ollama server - #282
Open
TheBlackSide243 wants to merge 1 commit into
Open
TheBlackSide243 wants to merge 1 commit into
TheBlackSide243 wants to merge 1 commit into
Conversation
OLLAMA_BASE_URL, OLLAMA_MODEL, OLLAMA_VISION_MODEL, OLLAMA_TEXT_MODEL and OLLAMA_TIMEOUT fill in the AI_* settings (the /v1 suffix is added for the OpenAI-compatible API). Ollama stays a separate service: Wardrowbe only calls its HTTP API and never runs or downloads a model itself. Endpoints a user adds in Settings > AI still take precedence; these are the default. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Sorry @TheBlackSide243, you've used your own review budget of 250,000 diff characters for the last 7 days. You can request another review in 6 days and 22 hours by commenting |
Reviewer's GuideIntroduces an external-Ollama configuration shorthand: Pydantic post-validation maps OLLAMA_* variables into the existing AI settings, Compose forwards them to the backend, and tests cover URL/model/timeout mapping and fallback behavior. Flow diagram for external Ollama settings mappingflowchart LR
Env[OLLAMA_* environment variables] --> Compose[docker-compose.yml backend environment]
Compose --> Settings[Settings.apply_ollama_settings]
Settings --> AI[AI_BASE_URL and AI_* settings]
AI --> Client[Wardrowbe HTTP client]
Client --> Ollama[External Ollama server]
User[User AI endpoints] --> AI
User -->|takes precedence| Client
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a shorthand for pointing Wardrowbe at an Ollama server that already runs elsewhere, such as another container on the same host or another machine.
OLLAMA_BASE_URLAI_BASE_URL, with/v1added for the OpenAI-compatible APIOLLAMA_MODELAI_VISION_MODELandAI_TEXT_MODELOLLAMA_VISION_MODEL/OLLAMA_TEXT_MODELOLLAMA_TIMEOUTAI_TIMEOUTdocker-compose.ymlpasses the variables through, and.env.exampledocuments them.The change is small and independent. It branches from
mainand touches onlyconfig.py, the compose file and.env.example.Type of Change
Checklist
Testing
ruff check,ruff format --checkand the full pytest suite, including the compose-to-settings checks intest_deploy_env.py.OLLAMA_BASE_URL=http://<nas>:30068).Test Environment
🤖 Generated with Claude Code
Summary by Sourcery
Enable Wardrowbe to use an existing external Ollama server through environment-based configuration.
New Features:
Enhancements:
Build:
Tests: