Repository navigation
feat: several photos per item, front/back views, accessories and per-photo background removal - #283
Open
TheBlackSide243 wants to merge 8 commits into
Open
TheBlackSide243 wants to merge 8 commits into
TheBlackSide243 wants to merge 8 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…d 'fork/pr/background-removal-accuracy' into pr/item-photos
The upload handlers queued background removal only together with AI tagging, so with tagging skipped or disabled the option was silently ignored. The removal is now queued on its own and the worker marks the item ready; a failed enqueue no longer strands the item in processing. The 'only tags' test asserts the single tagging job and its queue. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Backups are written through a temporary file and swapped in, so an interrupted write never leaves a truncated original to restore from. - Rotation turns the backup only after the photo and its sizes are saved. - Smaller detached parts (straps, hoods) are kept and small garments such as jewellery are no longer rejected as empty cut-outs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…per-photo background removal - Up to 10 photos per item; each can be labelled front, back, detail or other (item_photo_views table, keyed by the photo's file so the label follows it when it becomes the cover). The gallery and the card show the back on hover. - Background removal runs per photo on the image worker, with its own status and backup (item_images.status / original_image_path / processing_started_at); the item's button and the bulk action also clean the other photos, and each photo can be restored. - Photos are shown whole (object-fit: contain), never cropped. - Accessory types (ring, necklace, watch, bracelet, earrings) and a category filter (tops, bottoms, outerwear, shoes, accessories...) on the wardrobe page, with a category breakdown in analytics. - A softer colour palette with category, success, warning and info tokens. - The image worker caps rembg's threads and frees the model after 10 minutes idle (BG_REMOVAL_THREADS, BG_REMOVAL_IDLE_SECONDS). Builds on Anyesh#277 and Anyesh#278 (merged in here); the diff shrinks once they land. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…val-accuracy' into pr/item-photos
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Sorry @TheBlackSide243, your pull request is larger than the review limit of 150,000 diff characters |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Several photos per item, with what each one shows, plus accessory sections and photos that are never cropped.
MAX_ITEM_PHOTOS).item_photo_viewstable. It is keyed by the photo's file, so a label follows the photo when it becomes or stops being the cover.clothing_items.item_images.status,original_image_pathandprocessing_started_at, added by migrationa4c6e8f0b2d3.garment-fitclass (contain, centred) instead ofobject-cover. Trouser legs, sleeves and long dresses are no longer cut off.BG_REMOVAL_THREADS, default 2.BG_REMOVAL_IDLE_SECONDSwithout photos, default 600.Depends on #277 and #278. Both are merged into this branch, so the diff includes them until they land. Review those two first.
Type of Change
Checklist
Testing
mainplus feat: remove the background while uploading #277 and feat: more accurate background removal for clothes #278):ruff checkandruff format --check;npm run lint,i18n:checkandtsc --noEmit;Test Environment
🤖 Generated with Claude Code