Repository navigation
Disable vim mode and remove dead code - #70
Merged
Merged
Conversation
The vim mode implementation was structurally broken: the editor bridge that connects vim motions to the buffer was never wired, so every editing operation silently no-op'd while the mode indicator claimed vim was active. Keys were consumed without editing, leaving users with a non-functional editor. Disable vim honestly instead of leaving the broken experience: /vim now reports that the feature is unavailable, the dead handler and tests are removed (730 LOC), all vim wiring is stripped from the TUI, the config flag is deprecated, and docs are updated. Emacs/readline-style keybindings remain available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The vim mode implementation was structurally broken: the editor bridge that connects vim motions to the buffer was never wired, so every editing operation silently no-op'd while the mode indicator claimed vim was active. Keys were consumed without editing, leaving users with a non-functional editor.
This disables vim honestly and removes the dead code:
/vimnow reports "vim mode is not available in this build" instead of toggling a non-functional mode.vim-handler.tsand its test suite (730 LOC of dead code).tui.ts,custom-editor.ts,tui-types.ts, andkeybinding-resolver.ts(thetoggleVimkeybinding was already dead — never dispatched).config.ui.vimwith an honest comment (kept for backward compat).Emacs/readline-style keybindings (Ctrl+A/E home/end, Ctrl+W delete word, Ctrl+U/K delete to line bounds) remain available via the editor.
Test plan
pnpm tsgo— 0 errorspnpm lint— 0 errors, 352 warningspnpm exec vitest run src/tui/— 505 passed, 1 skipped, 0 failed