Skip to content

Fix Apollos Preview version display on Apps page - #552

Merged
redreceipt merged 4 commits into
mainfrom
fix/apps-preview-store-version
Sep 26, 2026
Merged

redreceipt merged 4 commits into
mainfrom
fix/apps-preview-store-version

Conversation

@redreceipt

@redreceipt redreceipt commented Sep 26, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Look up public App Store versions for every iOS bundle in batches, isolating invalid (HTTP 400) batches while avoiding retries on timeouts or malformed responses.
  • Display the demo church as Demo and label the App Store version as live (App Store Connect 1.41 is pending developer release; public lookup reports 1.40).

Validation

  • 214 unit tests; Ruff check/format and mypy pass.

Proof

  • Local /apps runtime with disposable Segment-like fixtures and a real Apple lookup; screenshot attached below. The preview row shows Demo, Observed 1.0.0, and App Store (live) 1.40. A separate real HTTP response verified the preview after 24 other iOS bundles still receives the live version.

Apps page showing Apollos Preview with live App Store 1.40

@redreceipt
redreceipt marked this pull request as ready for review September 26, 2026 00:08
Copilot AI lite review requested due to automatic review settings September 26, 2026 00:08
@redreceipt
redreceipt temporarily deployed to bug-board-fix-apps-prev-elhvw8 September 26, 2026 00:09 Inactive

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The batching test relies on nondeterministic thread scheduling and should use bundle-specific mock responses.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 Medium severity

Open (1)
What changed in this PR

Updates the Apps page to fetch public App Store versions for all iOS bundles and improve demo/live-version labeling.

Changes:

  • Batches concurrent App Store lookups beyond the previous 24-bundle limit.
  • Displays apollos_demo as “Demo”.
  • Labels public versions as “App Store (live)”.
  • Adds batching and rendering coverage.
File Summary
tests/​test_app_versions.py Adds coverage for batching and preview display.
templates/​app_versions.html Updates demo and live-version labels.
app_versions.py Implements batched concurrent App Store lookups.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread tests/test_app_versions.py
Copilot AI review requested due to automatic review settings September 26, 2026 00:17
@redreceipt
redreceipt temporarily deployed to bug-board-fix-apps-prev-elhvw8 September 26, 2026 00:18 Inactive
@redreceipt
redreceipt enabled auto-merge (squash) September 26, 2026 00:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Batch failures can cause unrelated apps to lose their public versions and fall back to observed versions.

Review effort: Lite
Findings: None

Resolved since last review (1)

Copilot AI review requested due to automatic review settings September 26, 2026 00:23
@redreceipt
redreceipt temporarily deployed to bug-board-fix-apps-prev-elhvw8 September 26, 2026 00:23 Inactive

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Bound fallback retries and validate malformed App Store responses before approval.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 Medium severity

Open (1)

Comment thread app_versions.py Outdated
Copilot AI review requested due to automatic review settings September 26, 2026 00:28
@redreceipt
redreceipt temporarily deployed to bug-board-fix-apps-prev-elhvw8 September 26, 2026 00:28 Inactive

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approved

All reviewed changes are covered and no unresolved blocking issues were identified.

Review effort: Lite
Findings: None

Resolved since last review (1)

@redreceipt
redreceipt merged commit 1e962a9 into main Sep 26, 2026
6 checks passed
@redreceipt
redreceipt deleted the fix/apps-preview-store-version branch September 26, 2026 00:30

This branch was previously deployed

1 inactive deployment
bug-board-fix-apps-prev-elhvw8 — 0aa86c31 Deployed Sep 26, 2026 by redreceipt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants