Fix Apollos Preview version display on Apps page - #552
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The batching test relies on nondeterministic thread scheduling and should use bundle-specific mock responses.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Updates the Apps page to fetch public App Store versions for all iOS bundles and improve demo/live-version labeling.
Changes:
- Batches concurrent App Store lookups beyond the previous 24-bundle limit.
- Displays
apollos_demoas “Demo”. - Labels public versions as “App Store (live)”.
- Adds batching and rendering coverage.
| File | Summary |
|---|---|
tests/test_app_versions.py |
Adds coverage for batching and preview display. |
templates/app_versions.html |
Updates demo and live-version labels. |
app_versions.py |
Implements batched concurrent App Store lookups. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Validation
Proof
/appsruntime with disposable Segment-like fixtures and a real Apple lookup; screenshot attached below. The preview row shows Demo, Observed 1.0.0, and App Store (live) 1.40. A separate real HTTP response verified the preview after 24 other iOS bundles still receives the live version.