Skip to content

fix(build): require Flutter 3.47 for Linux IME candidate positioning - #9062

Open
KeuqS wants to merge 1 commit into
AppFlowy-IO:mainfrom
KeuqS:fix/flutter-3-47-ime-candidate-position
Open

KeuqS wants to merge 1 commit into
AppFlowy-IO:mainfrom
KeuqS:fix/flutter-3-47-ime-candidate-position

Conversation

@KeuqS

@KeuqS KeuqS commented Oct 11, 2026 •

Copy link
Copy Markdown

Summary

This updates AppFlowy Flutter SDK requirements and build environments to Flutter 3.47.0, which includes the upstream Linux text-input fix for stale IME widget references.

Why

With Flutter 3.27.4, Fcitx5 candidate windows can remain pinned to an incorrect position after an FlView is disposed. The upstream Flutter fix landed in 3.47.0. AppFlowy current minimum and CI/CodeMagic versions still allow or select the affected 3.27.4 release.

Changes

  • Raise the Flutter SDK constraint in pubspec.yaml and pubspec.lock to >=3.47.0.
  • Update Flutter versions used by Flutter CI, iOS CI, release, Rust coverage, and CodeMagic to 3.47.0.

Fixes #8997

Testing

  • git diff --check
  • Verified all active build configuration references to Flutter 3.27.4 were updated; the only remaining reference is the archived .github/workflows/android_ci.yaml.bak file.
  • Flutter tests were not run because the Flutter SDK is not installed in this environment.

Summary by Sourcery

Require Flutter 3.47.0 across the project to resolve Linux IME candidate positioning issues.

Bug Fixes:

  • Require Flutter 3.47.0 to include the upstream Linux IME candidate-positioning fix and prevent stale candidate windows after FlView disposal.

Build:

  • Raise the Flutter SDK minimum and update Flutter versions across CI, release, coverage, and CodeMagic build environments.

@sourcery-ai

sourcery-ai Bot commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR raises AppFlowy’s minimum Flutter SDK to 3.47.0 and updates all active CI, release, coverage, and CodeMagic configurations to use that version, ensuring the Linux IME candidate-positioning fix is included consistently across development and build environments.

File-Level Changes

Change Details Files
Raise the Flutter SDK minimum and lockfile requirement to the version containing the Linux IME positioning fix.
  • Set the package Flutter constraint to >=3.47.0.
  • Regenerate the lockfile metadata for the updated SDK requirement.
frontend/appflowy_flutter/pubspec.yaml
frontend/appflowy_flutter/pubspec.lock
Standardize automated and release build environments on Flutter 3.47.0.
  • Update Flutter versions in Flutter, iOS, release, and Rust coverage workflows.
  • Update the CodeMagic Flutter environment version.
.github/workflows/flutter_ci.yaml
.github/workflows/ios_ci.yaml
.github/workflows/release.yml
.github/workflows/rust_coverage.yml
codemagic.yaml

Assessment against linked issues

Issue Objective Addressed Explanation
#8997 Ensure AppFlowy uses a Flutter version containing the upstream Linux IME candidate-positioning fix for stale Fcitx5 widget references. ✅
#8997 Raise the minimum Flutter SDK requirement so builds cannot use the affected Flutter 3.27.4 release. ✅
#8997 Update active CI, release, and CodeMagic build configurations to use Flutter 3.47.0 consistently. ✅

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="frontend/appflowy_flutter/pubspec.yaml" line_range="10" />
<code_context>
 sdks:
   dart: ">=3.6.2 <4.0.0"
-  flutter: ">=3.27.4"
+  flutter: ">=3.47.0"
</code_context>
<issue_to_address>
**Flutter builds reject the installed SDK**

When the Docker image is built or a checked-in platform setup script is used, the Dockerfile and setup scripts select Flutter 3.27.4, so `flutter pub get` rejects the new minimum and Docker/release builds and local app builds fail.

Update the Dockerfile and setup scripts to use Flutter 3.47.0 or newer, or keep the pubspec minimum compatible with Flutter 3.27.4.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

Comment thread frontend/appflowy_flutter/pubspec.yaml Resolved
@KeuqS

KeuqS commented Oct 22, 2026

Copy link
Copy Markdown
Author

Just to clarify, I’m an individual contributor—not a bot. I’ve grown tired of being repeatedly labeled that way, so I’ve decided to focus exclusively on my own projects and will not be contributing to other projects going forward. If you have a specific request for my involvement, you’re welcome to contact me directly.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Incorrect candidate box position of IME (Fcitx5) on Linux

1 participant