Repository navigation
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe PR raises AppFlowy’s minimum Flutter SDK to 3.47.0 and updates all active CI, release, coverage, and CodeMagic configurations to use that version, ensuring the Linux IME candidate-positioning fix is included consistently across development and build environments. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="frontend/appflowy_flutter/pubspec.yaml" line_range="10" />
<code_context>
sdks:
dart: ">=3.6.2 <4.0.0"
- flutter: ">=3.27.4"
+ flutter: ">=3.47.0"
</code_context>
<issue_to_address>
**Flutter builds reject the installed SDK**
When the Docker image is built or a checked-in platform setup script is used, the Dockerfile and setup scripts select Flutter 3.27.4, so `flutter pub get` rejects the new minimum and Docker/release builds and local app builds fail.
Update the Dockerfile and setup scripts to use Flutter 3.47.0 or newer, or keep the pubspec minimum compatible with Flutter 3.27.4.
</issue_to_address>
Author
|
Just to clarify, I’m an individual contributor—not a bot. I’ve grown tired of being repeatedly labeled that way, so I’ve decided to focus exclusively on my own projects and will not be contributing to other projects going forward. If you have a specific request for my involvement, you’re welcome to contact me directly. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This updates AppFlowy Flutter SDK requirements and build environments to Flutter 3.47.0, which includes the upstream Linux text-input fix for stale IME widget references.
Why
With Flutter 3.27.4, Fcitx5 candidate windows can remain pinned to an incorrect position after an FlView is disposed. The upstream Flutter fix landed in 3.47.0. AppFlowy current minimum and CI/CodeMagic versions still allow or select the affected 3.27.4 release.
Changes
Fixes #8997
Testing
Summary by Sourcery
Require Flutter 3.47.0 across the project to resolve Linux IME candidate positioning issues.
Bug Fixes:
Build: