Repository navigation
AQI-11674: Add PropertyBag to ReportDefinitionRun - #147
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The protobuf source supplying the documented property is not updated.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
What changed in this PR
Prepares release 7.36.0 for the intended ReportDefinitionRun.PropertyBag addition, but omits the required protobuf submodule update.
Changes:
- Bumps package version to 7.36.0.
- Adds a release-note entry.
| File | Description |
|---|---|
ONE.Models.CSharp.csproj |
Updates package version. |
CHANGELOG.md |
Documents the intended property addition. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| ### Added | ||
|
|
||
| - Added nullable `PropertyBag` (`StringValue`, protobuf field 11) to `ReportDefinitionRun`. |
Contributor
Author
There was a problem hiding this comment.
The submodule is pointing to a commit with PropertyBag.
mathitharmalingam-aqi
force-pushed
the
feature/AQI-11674
branch
from
September 25, 2026 20:37
9ad3eba to
c4be513
Compare
AQI-DanG
previously approved these changes
Oct 13, 2026
AQI-DanG
approved these changes
Oct 13, 2026
elijahquinonez-aqi
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.