Skip to content

fix: allow subagents to use web search tools#9357

Open
tokenicrat wants to merge 1 commit into
AstrBotDevs:masterfrom
tokenicrat:fix/9354
Open

fix: allow subagents to use web search tools#9357
tokenicrat wants to merge 1 commit into
AstrBotDevs:masterfrom
tokenicrat:fix/9354

Conversation

@tokenicrat

@tokenicrat tokenicrat commented Jul 23, 2026

Copy link
Copy Markdown

修复 #9354

Modifications / 改动点

移植 astrbot/core/astr_main_agent.py_apply_web_search_tools 方法到 astrbot/core/astr_agent_tool_exec.py,调用这个方法添加配置中启用的网络搜索工具。

  • This is NOT a breaking change. / 这不是一个破坏性变更。

这个 PR 引入了一些重复,因为原始的 _apply_web_search_tools 需要 event 参数,astr_agent_tool_exec.py 没有,为了复用创建一个假 event 太别扭了

另外,这个 PR 没有实现其他由 _apply_*_tools 提供的工具,涉及安全问题,我希望维护者来决定是否引入

Screenshots or Test Results / 运行截图或测试结果

WebUI 对话询问:

你可以使用哪些工具?另外,用 transfer_to_test_sub 工具问一下 test_sub 可以用哪些工具。

改动前:

改动后:


Checklist / 检查清单

  • 😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
    / 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。
    (不适用)

  • 👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
    / 我的更改经过了良好的测试,并已在上方提供了“验证步骤”和“运行截图”

  • 🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in requirements.txt and pyproject.toml.
    / 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到 requirements.txtpyproject.toml 文件相应位置。

  • 😮 My changes do not introduce malicious code.
    / 我的更改没有引入恶意代码。

Summary by Sourcery

Bug Fixes:

  • Ensure sub-agents receive the same configured web search tools as the main agent when building handoff toolsets.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. area:core The bug / feature is about astrbot's core, backend labels Jul 23, 2026

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The new _get_web_search_tools implementation duplicates the logic already present in astr_main_agent._apply_web_search_tools; consider extracting a shared helper (e.g., in a separate module) to keep provider-specific logic in one place and avoid divergence over time.
  • In _get_web_search_tools, when websearch_provider is an unknown value the function silently returns an empty list; it may be safer to log or raise on unsupported providers so misconfigurations are easier to detect.
  • When matching web tools by name in _build_handoff_toolset, you currently do a linear search over web_search_tools for every tool_name_or_obj; if the tool list grows, consider building a {name: tool} map once to avoid repeated scans.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The new `_get_web_search_tools` implementation duplicates the logic already present in `astr_main_agent._apply_web_search_tools`; consider extracting a shared helper (e.g., in a separate module) to keep provider-specific logic in one place and avoid divergence over time.
- In `_get_web_search_tools`, when `websearch_provider` is an unknown value the function silently returns an empty list; it may be safer to log or raise on unsupported providers so misconfigurations are easier to detect.
- When matching web tools by name in `_build_handoff_toolset`, you currently do a linear search over `web_search_tools` for every `tool_name_or_obj`; if the tool list grows, consider building a `{name: tool}` map once to avoid repeated scans.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:core The bug / feature is about astrbot's core, backend size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant