Bulk MultiQC reporting as a pipeline-installed Python module - #45
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
|
…line Implement 'bulk' MultiQC reporting as a pipeline-installed Python module. - Add/setup module packaging for multiqc_proteinfold - won't be upstreamed into MultiQC as per Phil's comments PR#3462 - Install module from pipeline runtime with Docker linting behavior (escaping PWD) - Handle pip target/PYTHONPATH and improve install robustness - Ensure MultiQC YAML packag usable - Apply related lint/format cleanup (e.g. escape PWD) rank typo Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> use logger not print Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> remove unused multiqc modules Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> typos Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> makesure user can specify sample merge rules make nextflow lint happy by using shell substitution not VARS docker container doesn't like shell substitution without escape chars
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> remove SBF logo and custom links
a816184 to
2a402a2
Compare
This comment was marked as outdated.
This comment was marked as outdated.
…use in comparison report
2a402a2 to
5cb1311
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
Also add setuptools/wheel to the module env (required by --no-build-isolation, conda-forge python >=3.12 no longer bundles setuptools)
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Nice simplification moving bulk reporting to a pipeline-local MultiQC plugin. I've updated the multiqc module to 1.35 (via nf-tools) and added |
jscgh
left a comment
There was a problem hiding this comment.
I'm getting blank sections of reports running the current branch. I've tried to trace the sources and commented on them.
This reverts commit e4502f5.
|
I hadn't noticed the agent swapped It makes it more explicit, but happy to revert to simplify the install process. |
Sort ranked models, make the embedded config JSON injection-safe, de-duplicate model images and fix rendering for the ipTM/ipSAE/chainwise tables.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
jscgh
left a comment
There was a problem hiding this comment.
Thanks! I can tell this was a huge body of work. 🚀
I was able to rebuild the plugin into a small module with mqc custom-content files, so we can use the native nf-core/multiqc version. This should help with keeping it up to date and changing things locally in the future.
I also added some tests for reports to make it easier to track drift.
Implements 'bulk' MultiQC reporting as per proteinfold/issues/439.
Recommendation from Phil Ewels when evaluating contribute into MultiQC modules was instead using setup.py in this specific pipeline whereas MultiQC modules typically work with only one CLI tool (MultiQC/MultiQC#3462)