fix: displayed submittedAt diverging its DB sort key - #181
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Fix job displayed date diverging from its actual sort position
On the Jobs page, a job could appear out of order relative to its neighbors — e.g. a job submitted today showing up mid-list instead of first when sorted by Submitted (desc)
Root cause:
_build_job_list_itemdisplayedsubmittedAtfrom a live Seqera payload's own "submit" field when one was fetched, but the SQL query sorts by the DB's submission_timestamp column — these can differ for any job that still needs a live Seqera check (i.e. not yet marked finalized in the DB), so the row lands in its correct DB-sorted position but shows a date that contradicts itFix
Prefer
owned_run.submission_timestamp(the DB column, always set at creation, and what the SQL query actually sorts by) over the live payload's timestamp, falling back to it only if the DB column is somehow unsetAdded a regression test: a job with an old DB submission_timestamp but a live payload reporting "today" now displays the old (correctly-sorted) date, not the misleading live one
How to Test
CI tests shall pass
Type of change
Checklist